chore: Fix release and CI process for the ClientSDK#98
Merged
jsonbailey merged 5 commits intomainfrom May 12, 2025
Merged
Conversation
We cannot build the client with .NET8 or higher with the maui workloads and still target net6. (https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1202) Moved the copy global.json into the workflow so the dotnet version is consistent across steps.
tanderson-ld
approved these changes
May 8, 2025
Contributor
Author
|
I pushed this branch mainly as a proof of concept. I'm not sure if we want to enforce the global.json file for local development or not but it does look like it needs to be enforced for at least the CI action (this PR removes that but its the current behavior on main) and the build-release action which doesn't support it and caused a failure when releasing the ClientSDK. |
This reverts commit c3f43e9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot build the client with .NET8 or higher with the maui workloads and still target net6. (https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1202) Enabled the global.json during the release build so the dotnet version is consistent with CI.