Merged
Conversation
Co-authored-by: Adam M. Dempsey <adamdemps@gmail.com>
adamdempsey90
approved these changes
Mar 20, 2026
Collaborator
|
You need to run clang-format on the files in reconstruction/. Because you are in a fork, that is not easy for me to do for you. |
auto-merge was automatically disabled
March 20, 2026 22:03
Head branch was pushed to by a user without write access
Collaborator
Author
|
my bad, should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have attempted to add two variations of WENO-Z reconstruction. The first follows Borges et al. 2008 and the improvements suggested in Castro et al. 2011 and is called WENO-Z. I have also implemented WENO-MZ as a reconstruction option, which should have better resolution of smooth features, even in the presence of shocks.
Here are a couple examples of the accuracy for a quick linear wave test, and a demonstration that they are stable for simple shock tube.
