Self-Gravitating Slab Advection#115
Merged
adamdempsey90 merged 3 commits intodevelopfrom Mar 16, 2026
Merged
Conversation
adamdempsey90
approved these changes
Mar 10, 2026
Comment on lines
+40
to
+56
| nx1 = 128 # Number of zones in X1-direction | ||
| x1min = 0.0 # minimum value of X1 | ||
| x1max = 18.84955592153876 # maximum value of X1 | ||
| ix1_bc = periodic # Inner-X1 boundary condition flag | ||
| ox1_bc = periodic # Outer-X1 boundary condition flag | ||
|
|
||
| nx2 = 64 # Number of zones in X2-direction | ||
| x2min = 0.0 # minimum value of X2 | ||
| x2max = 9.424777960769380 # maximum value of X2 | ||
| ix2_bc = periodic # Inner-X2 boundary condition flag | ||
| ox2_bc = periodic # Outer-X2 boundary condition flag | ||
|
|
||
| nx3 = 64 # Number of zones in X3-direction | ||
| x3min = 0.0 # minimum value of X3 | ||
| x3max = 9.424777960769380 # maximum value of X3 | ||
| ix3_bc = periodic # Inner-X3 boundary condition flag | ||
| ox3_bc = periodic # Outer-X3 boundary condition flag |
pdmullen
commented
Mar 10, 2026
pdmullen
commented
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The self-gravity module needed more quantitative testing (e.g., convergence analysis). This PR attempts to address this via an additional test.
Description of Changes
Adds the Hanawa & Mullen (2025) self-gravitating slab advection test
ProblemGenerator. Additionally enrolls it as a regression test in the CI framework.Checklist
// This file was created in part or in whole by generative AI