Skip to content

Add Self-Gravity#113

Merged
adamdempsey90 merged 23 commits intodevelopfrom
pdmullen/self-grav
Mar 1, 2026
Merged

Add Self-Gravity#113
adamdempsey90 merged 23 commits intodevelopfrom
pdmullen/self-grav

Conversation

@pdmullen
Copy link
Copy Markdown
Collaborator

Background

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@pdmullen pdmullen changed the title Draft: Debugging self-gravity Draft: Add Self-Gravity Dec 16, 2025
Comment thread src/gravity/gravity.cpp Outdated
Comment thread src/artemis_driver.cpp Outdated
Comment thread src/gravity/gravity.cpp Outdated
Comment thread src/gravity/poisson_driver.cpp Outdated
@pdmullen pdmullen changed the title Draft: Add Self-Gravity Add Self-Gravity Dec 17, 2025
Comment thread src/self_gravity/poisson_equation.hpp Outdated
Comment thread src/self_gravity/params.yaml
Comment thread inputs/self-gravity/poly.in Outdated
Comment thread src/self_gravity/self_gravity.cpp Outdated
Comment thread src/self_gravity/self_gravity.cpp Outdated
Comment thread src/self_gravity/self_gravity.hpp Outdated
Comment thread inputs/self-gravity/poly.in Outdated
Comment thread src/self_gravity/poisson_equation.hpp
Comment thread src/self_gravity/poisson_equation.hpp Outdated
@pdmullen pdmullen changed the title Add Self-Gravity WIP: Add Self-Gravity Feb 25, 2026
@pdmullen pdmullen changed the title WIP: Add Self-Gravity Add Self-Gravity Feb 26, 2026
Copy link
Copy Markdown
Collaborator

@adamdempsey90 adamdempsey90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion, then we can merge

Comment thread src/artemis.cpp Outdated
Comment thread src/self_gravity/self_gravity.cpp
@pdmullen pdmullen changed the title Add Self-Gravity WIP: Add Self-Gravity Feb 26, 2026
@pdmullen pdmullen changed the title WIP: Add Self-Gravity Add Self-Gravity Feb 27, 2026
@adamdempsey90
Copy link
Copy Markdown
Collaborator

Probably should've added a test, but I verified it works on device. Merging...

@adamdempsey90 adamdempsey90 merged commit 95de347 into develop Mar 1, 2026
6 checks passed
@adamdempsey90 adamdempsey90 deleted the pdmullen/self-grav branch March 1, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants