Skip to content

[BugFix] Fixes and improvements to H-He EOS#112

Merged
adamdempsey90 merged 14 commits intodevelopfrom
dempsey/table_fix
Feb 2, 2026
Merged

[BugFix] Fixes and improvements to H-He EOS#112
adamdempsey90 merged 14 commits intodevelopfrom
dempsey/table_fix

Conversation

@adamdempsey90
Copy link
Copy Markdown
Collaborator

Background

  • Does a better job of partition function calculations for molecular hydrogen.
  • Corrects a bug where I was using the non-equilibrium expression for the H2 energy, as well.
  • Correctly handle X=0 and Y=0 cases.

Contains all of the changes in the unit testing MR. The EOS unit test was very helpful in debugging and checking everything was working. I have improved it some more.

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

This is ready to go now.

@adamdempsey90 adamdempsey90 merged commit 528c158 into develop Feb 2, 2026
6 checks passed
@adamdempsey90 adamdempsey90 deleted the dempsey/table_fix branch February 2, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants