Skip to content

fix: Rebuild the embedding model in the nv template#12275

Open
erichare wants to merge 1 commit intorelease-1.9.0from
fix-nvidia-template
Open

fix: Rebuild the embedding model in the nv template#12275
erichare wants to merge 1 commit intorelease-1.9.0from
fix-nvidia-template

Conversation

@erichare
Copy link
Collaborator

@erichare erichare commented Mar 20, 2026

This pull request updates the Nvidia template to use the latest Embedding Model component, fixing a critical connection error when choosing an embedding model.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e4d8987-fcc6-458a-b429-f5d5c204cd1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-nvidia-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 20, 2026
@github-actions
Copy link
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 24%
24.38% (8698/35673) 17.21% (4831/28055) 17.06% (1275/7472)

Unit Test Results

Tests Skipped Failures Errors Time
2783 0 💤 0 ❌ 0 🔥 45.217s ⏱️

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.25%. Comparing base (15c803a) to head (685973b).

❌ Your project check has failed because the head coverage (44.68%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-1.9.0   #12275   +/-   ##
==============================================
  Coverage          38.25%   38.25%           
==============================================
  Files               1652     1652           
  Lines              82459    82459           
  Branches           12239    12239           
==============================================
  Hits               31548    31548           
  Misses             49116    49116           
  Partials            1795     1795           
Flag Coverage Δ
backend 54.68% <ø> (ø)
frontend 21.76% <ø> (ø)
lfx 44.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant