fix: forward Slack image attachments to queued follow-up messages#1184
Open
Johan Bonilla (johanity) wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix: forward Slack image attachments to queued follow-up messages#1184Johan Bonilla (johanity) wants to merge 1 commit intolangchain-ai:mainfrom
Johan Bonilla (johanity) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slack image attachments were silently dropped when a user sent a follow-up with an image while open-swe was already running on that thread.
process_slack_mentionbuilt the correctimage_urlslist from the thread context, but on the busy path hardcodedimage_urls=[]in the queued payload:check_message_queue_before_modelthen read an empty list and never fetched the images, so the agent saw the follow-up text but not the screenshot. Regression introduced in #1050.The rest of the queue pipeline — including Slack-auth in
fetch_image_block— was already wired correctly. Only the queue producer was missing the forward.This PR also reorders
process_slack_mentionso theis_thread_activecheck runs before the image fetch loop. Previously, images were fetched fromfiles.slack.comon the busy path even though the results were then discarded by theimage_urls=[]queue payload.On the busy path the queue now carries images filtered to the current mention only, not the full thread context. Re-injecting historical images would duplicate what the agent already saw in its prior turn.
Test Plan
New
tests/test_slack_image_queue.py:image_urlsfor a text-only follow-upcontent_blocksFull suite:
111 passed.