fix: pass encoding to partition_csv for CSV loader#538
Open
DoTA (dotuananh0712) wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix: pass encoding to partition_csv for CSV loader#538DoTA (dotuananh0712) wants to merge 1 commit intolangchain-ai:mainfrom
DoTA (dotuananh0712) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Fixes langchain-ai#505 - Need to pass encoding to partition_csv() to allow users to specify custom encodings for CSV files. Previously, encoding was passed via unstructured_kwargs but the unstructured library ignores kwargs for encoding, defaulting to utf-8. Now encoding is extracted from kwargs and passed directly to partition_csv. AI assistance used for code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnstructuredCSVLoaderwas being ignoredencodingfromunstructured_kwargsand passes it directly topartition_csv()Issue
When users pass
encodingviaunstructured_kwargs, theunstructuredlibrary ignores it and defaults to UTF-8, causingUnicodeDecodeErrorfor CSV files with other encodings.Fix
Testing
AI assistance used for code review and implementation