Skip to content

Fix test-seq{-with-skipped} with {root,nested} testable#451

Merged
joannecheng merged 2 commits intolambdaisland:mainfrom
frenchy64:fix-test-seq
Sep 17, 2025
Merged

Fix test-seq{-with-skipped} with {root,nested} testable#451
joannecheng merged 2 commits intolambdaisland:mainfrom
frenchy64:fix-test-seq

Conversation

@frenchy64
Copy link
Copy Markdown
Contributor

test-seq seems to ignore whether the outer testable is skipped, and test-seq-with-skipped omits skipped tests if they are nested.

@joannecheng
Copy link
Copy Markdown
Contributor

Thank you so much for this fix, sorry for the delay in getting this merged 🙏

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.62%. Comparing base (e789dad) to head (491ed9e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   74.50%   74.62%   +0.12%     
==========================================
  Files          52       52              
  Lines        2820     2822       +2     
  Branches      286      284       -2     
==========================================
+ Hits         2101     2106       +5     
+ Misses        523      521       -2     
+ Partials      196      195       -1     
Flag Coverage Δ
integration 54.32% <60.00%> (+0.06%) ⬆️
unit 69.31% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joannecheng joannecheng merged commit 65be913 into lambdaisland:main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants