Skip to content

refactor: polish the protocol for Delta Lake #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lonless9 wants to merge 4 commits into
base: main
Choose a base branch
from

fix

d83fd81
Select commit
Loading
Failed to load commit list.
Draft

refactor: polish the protocol for Delta Lake #1557

fix
d83fd81
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2026 in 0s

75.05% (+0.04%) compared to 1bb4bd6

View this Pull Request on Codecov

75.05% (+0.04%) compared to 1bb4bd6

Details

Codecov Report

❌ Patch coverage is 77.91953% with 225 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/sail-delta-lake/src/kernel/snapshot/mod.rs 87.42% 44 Missing ⚠️
...ta-lake/src/kernel/transaction/conflict_checker.rs 0.00% 41 Missing ⚠️
crates/sail-delta-lake/src/spec/actions.rs 29.41% 36 Missing ⚠️
crates/sail-delta-lake/src/kernel/checkpoints.rs 84.29% 30 Missing ⚠️
crates/sail-delta-lake/src/spec/statistics.rs 76.92% 18 Missing ⚠️
...sail-delta-lake/src/kernel/transaction/protocol.rs 77.94% 15 Missing ⚠️
crates/sail-delta-lake/src/table/features.rs 40.90% 13 Missing ⚠️
...ates/sail-delta-lake/src/kernel/transaction/mod.rs 84.00% 8 Missing ⚠️
...s/sail-delta-lake/src/physical_plan/commit_exec.rs 66.66% 6 Missing ⚠️
crates/sail-delta-lake/src/datasource/scan.rs 89.79% 5 Missing ⚠️
... and 2 more 
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   75.00%   75.05%   +0.04%     
==========================================
  Files         870      871       +1     
  Lines      114493   115398     +905     
==========================================
+ Hits        85877    86607     +730     
- Misses      28616    28791     +175
Files with missing lines Coverage Δ
crates/sail-delta-lake/src/delta_log/segment.rs 94.10% <100.00%> (+0.09%) ⬆️
...ates/sail-delta-lake/src/operations/write/stats.rs 68.79% <100.00%> (+0.07%) ⬆️
crates/sail-delta-lake/src/spec/action_schema.rs 100.00% <100.00%> (ø)
crates/sail-delta-lake/src/spec/checkpoint.rs 100.00% <100.00%> (ø)
crates/sail-delta-lake/src/spec/checksum.rs 100.00% <ø> (ø)
crates/sail-delta-lake/src/spec/error.rs 22.95% <ø> (ø)
crates/sail-delta-lake/src/table/mod.rs 73.02% <ø> (ø)
crates/sail-delta-lake/src/delta_log/replay.rs 71.91% <66.66%> (+0.48%) ⬆️
crates/sail-delta-lake/src/datasource/scan.rs 87.52% <89.79%> (-0.37%) ⬇️
crates/sail-delta-lake/src/spec/protocol.rs 82.69% <87.17%> (+31.92%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov