Use service hostname instead of pod IP as operator address.#66
Open
Use service hostname instead of pod IP as operator address.#66
Conversation
Member
|
Thanks, this looks cool, just one request: can we make this optional? We know of a couple of people running multiple operator instances. I think we can make this behavior the default, but we need a safe fallback for people running multiple operators. |
Author
|
Sure, I'll add that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error that prevents the operator from running at all in IPv6 or dual-stack (IPv6-first) clusters. I checked thru the code of the operator and stunner to make sure that it doesn't cause any unforeseen issues, and I've been running the chart with this change in my cluster for some time now.
One possible issue might be if one is running multiple replicas of the operator, but I believe that should be solved by only pointing the service at the pod which is currently acting as the leader, which would require changes to the operator.
But the stunner-auth service already uses this Service to discover configuration, which I assume means that is not a concern.