Closed
Conversation
Signed-off-by: Ananya Banerjee <anbanerj@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubevirt-bot
added
the
dco-signoff: yes
Member
|
/sig network |
Member
|
/cc |
Contributor
Author
|
Merging this with #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VEP Metadata
Tracking issue: #140
SIG label: /sig NETWORK
What this PR does
GA NAD live update
Special notes for your reviewer
We have
considered other bindingsas a part of the GAing process. The implementation of this NAD hotplug itself if binding agnostic.masqueradeandpasstbindings are supported for the primary network interface and is hence irrelevant for this feature. Hotplugging NAD refs of SRIOV interfaces should be possible provided the resource is present on the node the VM migrates to. Hotplugging NADs of Ifaces with binding plugins like macvtap will be possible as well as they do not require special resouces.The e2e test right now covers only the bridge binding. We can add other binding/plugins tests if there are more user requests.