Skip to content

VEP #141: Target Beta Graduation for v1.9#262

Open
Barakmor1 wants to merge 1 commit intokubevirt:mainfrom
Barakmor1:targethookbeta
Open

VEP #141: Target Beta Graduation for v1.9#262
Barakmor1 wants to merge 1 commit intokubevirt:mainfrom
Barakmor1:targethookbeta

Conversation

@Barakmor1
Copy link
Copy Markdown
Member

@Barakmor1 Barakmor1 commented Apr 14, 2026 •
edited
Loading

Remove the requirement to enable it by default, as it is now a global requirement.

VEP Metadata

Tracking issue:
#141

SIG label:
/sig sig-compute

What this PR does

Special notes for your reviewer

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 14, 2026
@Barakmor1 Barakmor1 changed the title Set v1.9 as the target version for XML mutation hooks. Set v1.9 as the target beta graduation version for XML mutation hooks Beta G. Apr 14, 2026
@Barakmor1 Barakmor1 changed the title Set v1.9 as the target beta graduation version for XML mutation hooks Beta G. VEP #156: Set v1.9 as the target beta graduation version for XML mutation hooks Beta. Apr 14, 2026
@Barakmor1 Barakmor1 changed the title VEP #156: Set v1.9 as the target beta graduation version for XML mutation hooks Beta. VEP #156: Set v1.9 as the target beta graduation version for XML mutation hooks Beta Apr 14, 2026
@Barakmor1 Barakmor1 changed the title VEP #156: Set v1.9 as the target beta graduation version for XML mutation hooks Beta VEP #141: Set v1.9 as the target beta graduation version for XML mutation hooks Beta Apr 14, 2026
@Barakmor1 Barakmor1 mentioned this pull request Apr 14, 2026
Open
11 tasks
lyarwood
lyarwood reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Simple nit to explicitly list the remaining modifications to migrate but otherwise I think this is good to graduate in 1.9.

Comment thread veps/sig-compute/target-xml-mutation-hooks.md Outdated
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2026
@Barakmor1 Barakmor1 changed the title VEP #141: Set v1.9 as the target beta graduation version for XML mutation hooks Beta VEP #141: Set v1.9 as the target beta graduation version Apr 15, 2026
@Barakmor1 Barakmor1 changed the title VEP #141: Set v1.9 as the target beta graduation version VEP #141: Target Beta Graduation for v1.9 Apr 15, 2026
xpivarc
xpivarc reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Comment thread veps/sig-compute/target-xml-mutation-hooks.md Outdated
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2026
@kubevirt-bot
Copy link
Copy Markdown

kubevirt-bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@kubevirt-bot kubevirt-bot added sig/compute and removed lgtm Indicates that a PR is ready to be merged. labels Apr 19, 2026
orelmisan
orelmisan reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Barakmor1.
I support this graduation, as it is a prerequisite for enabling the functionality of VEP #111 by default.

Comment thread veps/sig-compute/target-xml-mutation-hooks.md Outdated
Comment thread veps/sig-compute/target-xml-mutation-hooks.md
Comment thread veps/sig-compute/target-xml-mutation-hooks.md
### Beta
- Enable feature gate by default.
- Migrate all existing XML modifications from source to target-side hooks (dedicated CPU pinning, etc.).
- Migrate all target-based modifications from source to target-side hooks (dedicated CPU pinning, disk source path for cross-namespace or cross-cluster live migration).
Copy link
Copy Markdown
Member

@orelmisan orelmisan Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any potential issues when upgrading the cluster from a version which had the FG turned off?

Copy link
Copy Markdown
Member Author

@Barakmor1 Barakmor1 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the final XML is always identical, as the same modification log is applied during migration to the target.

Copy link
Copy Markdown
Member

@orelmisan orelmisan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the logic won't drift between versions.

Copy link
Copy Markdown
Member Author

@Barakmor1 Barakmor1 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the logic changes, the final XML will be determined by the target hook.

@Barakmor1
Set v1.9 as the target version for XML mutation hooks.
06b4827 
Remove the requirement to enable it by default, as it is now a global requirement.

Signed-off-by: bmordeha <bmordeha@redhat.com>
orelmisan
orelmisan approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Barakmor1!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@vladikr
Copy link
Copy Markdown
Member

vladikr commented Apr 23, 2026

Looks good to me!
@xpivarc do we still need the hold?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xpivarc xpivarc xpivarc left review comments

@vladikr vladikr Awaiting requested review from vladikr

+2 more reviewers

@lyarwood lyarwood lyarwood left review comments

@orelmisan orelmisan orelmisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lyarwood lyarwood

@orelmisan orelmisan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. sig/compute size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Barakmor1 @kubevirt-bot @vladikr @lyarwood @xpivarc @orelmisan