Skip to content

To be merged for 2.8.0 - MTV-2032 Attribute Update for 2.8.0#631

Closed
Pkylas007 wants to merge 2 commits intokubev2v:mainfrom
Pkylas007:MTV-2032-Attributes-Update
Closed

To be merged for 2.8.0 - MTV-2032 Attribute Update for 2.8.0#631
Pkylas007 wants to merge 2 commits intokubev2v:mainfrom
Pkylas007:MTV-2032-Attributes-Update

Conversation

@Pkylas007
Copy link
Copy Markdown
Collaborator

JIRA

@Pkylas007 Pkylas007 force-pushed the MTV-2032-Attributes-Update branch 2 times, most recently from 2a8a6f7 to ca41f06 Compare February 24, 2025 09:44
@Pkylas007 Pkylas007 force-pushed the MTV-2032-Attributes-Update branch 2 times, most recently from 3ca7949 to c619919 Compare February 24, 2025 10:20
@Pkylas007 Pkylas007 force-pushed the MTV-2032-Attributes-Update branch from c619919 to a141b2e Compare March 20, 2025 01:46
@Pkylas007
Copy link
Copy Markdown
Collaborator Author

@anarnold97 please can you review this PR update?

@anarnold97 anarnold97 changed the title MTV-2032 Attribute Update for 2.8.0 To be merged for 2.8.0 - MTV-2032 Attribute Update for 2.8.0 Mar 20, 2025
@anarnold97 anarnold97 requested a review from RichardHoch March 20, 2025 10:31
@anarnold97
Copy link
Copy Markdown
Collaborator

@RichardHoch this LGTM... but can you do the merge review as second eyes for me

and click merge if it is good to go

Thanks

@RichardHoch
Copy link
Copy Markdown
Collaborator

@anarnold97 @Pkylas007 Won't this change mean that we say MTV 2.8.0 works with OCP 4.15? Is that OK?

@anarnold97
Copy link
Copy Markdown
Collaborator

@anarnold97 @Pkylas007 Won't this change mean that we say MTV 2.8.0 works with OCP 4.15? Is that OK?

@RichardHoch & @Pkylas007 - could one of you ping the MTV channel and do a double-check

Thanks

@Pkylas007
Copy link
Copy Markdown
Collaborator Author

Pkylas007 commented Mar 20, 2025

@anarnold97 @Pkylas007 Won't this change mean that we say MTV 2.8.0 works with OCP 4.15? Is that OK?

@anarnold97 @Pkylas007 Won't this change mean that we say MTV 2.8.0 works with OCP 4.15? Is that OK?

@RichardHoch & @Pkylas007 - could one of you ping the MTV channel and do a double-check

Thanks

Checking, just pinged the MTV forum. Martin confirmed that MTV 2.8 works with OCP 5.16-4.18. Thanks @RichardHoch , I have removed 4.15 from the attributes doc.

@RichardHoch
Copy link
Copy Markdown
Collaborator

@Pkylas007 Why remove the comment in common-attributes.adoc? it's a good reminder.
Looks like there is no change to any of the attributes. If so, I suggest closing this PR.

@Pkylas007
Copy link
Copy Markdown
Collaborator Author

@Pkylas007 Why remove the comment in common-attributes.adoc? it's a good reminder. Looks like there is no change to any of the attributes. If so, I suggest closing this PR.

This attribute update included 4.18 OCP version which I'm not sure was present in MTV 2.7 attributes.

@RichardHoch
Copy link
Copy Markdown
Collaborator

@Pkylas007 Why remove the comment in common-attributes.adoc? it's a good reminder. Looks like there is no change to any of the attributes. If so, I suggest closing this PR.

This attribute update included 4.18 OCP version which I'm not sure was present in MTV 2.7 attributes.

@Pkylas007 We didn't want OCP 4.18 in the MTV 2.7 attributes. The current main branch is for MTV 2.8. Let's chat on Slack, please.

@anarnold97 anarnold97 closed this Mar 20, 2025
@anarnold97
Copy link
Copy Markdown
Collaborator

@RichardHoch - it is all dealt with

i forgot you had changed the attributes in https://github.com/kubev2v/forklift-documentation/pull/641/files

which renders this ticket and PR obsolete. Closed as such. Sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants