To be merged for 2.8.0 - MTV-2032 Attribute Update for 2.8.0#631
To be merged for 2.8.0 - MTV-2032 Attribute Update for 2.8.0#631Pkylas007 wants to merge 2 commits intokubev2v:mainfrom
Conversation
2a8a6f7 to
ca41f06
Compare
3ca7949 to
c619919
Compare
c619919 to
a141b2e
Compare
|
@anarnold97 please can you review this PR update? |
|
@RichardHoch this LGTM... but can you do the merge review as second eyes for me and click merge if it is good to go Thanks |
|
@anarnold97 @Pkylas007 Won't this change mean that we say MTV 2.8.0 works with OCP 4.15? Is that OK? |
@RichardHoch & @Pkylas007 - could one of you ping the MTV channel and do a double-check Thanks |
Checking, just pinged the MTV forum. Martin confirmed that MTV 2.8 works with OCP 5.16-4.18. Thanks @RichardHoch , I have removed 4.15 from the attributes doc. |
|
@Pkylas007 Why remove the comment in common-attributes.adoc? it's a good reminder. |
This attribute update included 4.18 OCP version which I'm not sure was present in MTV 2.7 attributes. |
@Pkylas007 We didn't want OCP 4.18 in the MTV 2.7 attributes. The current main branch is for MTV 2.8. Let's chat on Slack, please. |
|
@RichardHoch - it is all dealt with i forgot you had changed the attributes in https://github.com/kubev2v/forklift-documentation/pull/641/files which renders this ticket and PR obsolete. Closed as such. Sorry for the confusion |
JIRA