Skip to content

docs: add missing OpenBao reference to concepts.md #2015

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
kangetsu121:add-missing-openbao
Mar 22, 2026
Merged

docs: add missing OpenBao reference to concepts.md #2015
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
kangetsu121:add-missing-openbao

Conversation

@kangetsu121
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

#1914 added missing documentation for opnebao-csi-providers, but a reference in concepts.md was still missing. This PR adds that missing OpenBao reference and also fixes a few minor Markdown syntax issues.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Special notes for your reviewer:

This is a small documentation-only change.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Signed-off-by: kangetsu121 <kangetsu121@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 21, 2026
@k8s-ci-robot k8s-ci-robot requested review from aramase and ritazh March 21, 2026 09:48
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 21, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kangetsu121 / name: kangetsu121 (87e283b)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @kangetsu121!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kangetsu121. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2026
@enj enj moved this to Subprojects - Needs Triage in SIG Auth Mar 21, 2026
@enj enj added this to SIG Auth Mar 21, 2026
Copy link
Copy Markdown
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all other spurious changes.

@github-project-automation github-project-automation bot moved this from Subprojects - Needs Triage to Changes Requested in SIG Auth Mar 21, 2026
@kangetsu121 kangetsu121 force-pushed the add-missing-openbao branch from 0e5354d to 87e283b Compare March 22, 2026 00:35
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2026
@kangetsu121
Copy link
Copy Markdown
Contributor Author

@aramase
Thank you for the review and for pointing that out.

I’ve removed the unrelated changes and updated the branch accordingly.
Could you please review it again when you have a chance?

@kangetsu121 kangetsu121 requested a review from aramase March 22, 2026 00:38
@aramase
Copy link
Copy Markdown
Member

aramase commented Mar 22, 2026

/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2026
Copy link
Copy Markdown
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@github-project-automation github-project-automation bot moved this from Changes Requested to In Review in SIG Auth Mar 22, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, kangetsu121

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.07%. Comparing base (fd0c075) to head (87e283b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2015   +/-   ##
=======================================
  Coverage   22.07%   22.07%           
=======================================
  Files          57       57           
  Lines        3198     3198           
=======================================
  Hits          706      706           
  Misses       2400     2400           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot k8s-ci-robot merged commit d28532c into kubernetes-sigs:main Mar 22, 2026
26 of 27 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants