Ingress NGINX - Support Redirect by jgreeer · Pull Request #299 · kubernetes-sigs/ingress2gateway

jgreeer · 2026-01-09T21:10:36Z

What type of PR is this?

Fixes #268

Does this PR introduce a user-facing change?:

Add support for `nginx.ingress.kubernetes.io/permanent-redirect` and `nginx.ingress.kubernetes.io/temporal-redirect` + warnings for `nginx.ingress.kubernetes.io/proxy-redirect-from` and `nginx.ingress.kubernetes.io/proxy-redirect-to`

k8s-ci-robot · 2026-01-09T21:10:47Z

Hi @jgreeer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jgreeer · 2026-01-15T19:34:22Z

nginx.ingress.kubernetes.io/from-to-www-redirect, nginx.ingress.kubernetes.io/permanent-redirect-code, and nginx.ingress.kubernetes.io/temporal-redirect-code require 307/308 status code support, so they cannot be implemented until v1.5 release.

Stevenjin8 · 2026-01-22T18:18:03Z

tbh gwapi 1.5 is just around the corner. I think we can merge this as is. WDYT @mikemorris

jgreeer · 2026-01-23T20:53:55Z

tbh gwapi 1.5 is just around the corner. I think we can merge this as is. WDYT @mikemorris

this doesn't have the 307/308 status codes, it emits warnings for them. so we can merge now and then make another PR later for the status code annotations.

Stevenjin8 · 2026-01-28T20:02:55Z

/ok-to-test

pkg/i2gw/providers/ingressnginx/redirect.go

pkg/i2gw/providers/ingressnginx/annotations.go

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

pkg/i2gw/providers/ingressnginx/redirect_test.go

Stevenjin8 · 2026-02-03T20:27:15Z

/approve

k8s-ci-robot · 2026-02-03T20:27:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgreeer, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Stevenjin8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bexxmodd · 2026-02-05T17:48:26Z

pkg/i2gw/providers/ingressnginx/redirect.go

+
+				// Set port if present
+				if parsedURL.Port() != "" {
+					port, err := strconv.Atoi(parsedURL.Port())


Why are we ignoring this error? Let's append to errs.

This did get me thinking... we could have named ports here right?

this does gets caught by url.Parse() before we reach this, but i added a check to be safe. also not sure what you mean steven?

@jgreeer i just reread this and what I said makes no sense

@jgreeer Atoi can only really fail if the port overflows int, which shouldn't be possible unless you are actively trying to mess up. This seems fine.

…patibility with kubernetes-sigs#299

kkk777-7 · 2026-02-12T00:33:05Z

pkg/i2gw/providers/ingressnginx/redirect.go

+					[]gatewayv1.HTTPRouteRule{redirectRule},
+					httpRouteContext.HTTPRoute.Spec.Rules...,
+				)
+


should we add BackendSource to adjust rule index?

RuleBackendSources[i][j] is the source of the jth backend in the ith element of HTTPRoute.Spec.Rules.
https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/provider_intermediate/intermediate_representation.go#L70-L71

right, fixed this by adding the rule in backendsources but with no backends since it just redirects

the semantics are a bit weird on this but this sounds reasonable to me

actually, couldn't you just add the requestRedirect to the existing rule? that might be better

this breaks when you have a path that redirects and a path that doesn't, trying to fix now

kkk777-7 · 2026-02-12T00:43:41Z

pkg/i2gw/providers/ingressnginx/redirect_test.go

nits:
current tests look removed. e.g. TestAddDefaultSSLRedirect_disabledByAnnotation
could you rebase or merge main branch?

jgreeer · 2026-02-13T23:51:18Z

Changed approach to the following:

Iterate through all rules in the IR
Find a rule that has a source ingress with a redirect annotation
Add the redirect filter to that rule using values from URL.parse()
Remove backendRef from that rule (yaml isn't accepted if we don't do this)
Keep existing backendSource since it still contributed that rule

Also, always override the path with "/". Gateway api will keep the path from the match in the redirect, ingress-nginx does not.

added temoporal and permanent redirect

363d20e

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2026

k8s-ci-robot requested a review from LiorLieberman January 9, 2026 21:10

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2026

k8s-ci-robot requested a review from Stevenjin8 January 9, 2026 21:10

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2026

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2026

jgreeer added 2 commits January 9, 2026 16:18

moved annotations to annotations.go

a969c7b

start of adding status codes

d67662b

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026

Merge branch 'main' into ingress-nginx/support-redirect

584206e

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026

jgreeer added 2 commits January 14, 2026 17:13

add more redirect annotations to file

222d591

remove status codes and warn about those annotations

08cc6f6

jgreeer added 2 commits January 16, 2026 16:40

parse URL and set for redirect

6edbfa0

add warnings for proxy-redirect annotations

3e3c4d4

jgreeer marked this pull request as ready for review January 16, 2026 18:16

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2026

k8s-ci-robot requested a review from rikatz January 16, 2026 18:16

jgreeer temporarily deployed to release January 22, 2026 18:18 — with GitHub Actions Inactive

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026

Merge branch 'main' into ingress-nginx/support-redirect

01fb5bf

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026

fix imports

712e81c

jgreeer mentioned this pull request Jan 26, 2026

feat(ingressnginx): implement redirect annotation support #316

Closed

5 tasks

Stevenjin8 reviewed Jan 28, 2026

View reviewed changes

pkg/i2gw/providers/ingressnginx/redirect.go Outdated Show resolved Hide resolved

Stevenjin8 reviewed Jan 28, 2026

View reviewed changes

pkg/i2gw/providers/ingressnginx/redirect.go Outdated Show resolved Hide resolved

Stevenjin8 reviewed Jan 28, 2026

View reviewed changes

pkg/i2gw/providers/ingressnginx/annotations.go Show resolved Hide resolved

jgreeer and others added 3 commits January 28, 2026 16:44

Update pkg/i2gw/providers/ingressnginx/redirect.go

26f8b91

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

Update pkg/i2gw/providers/ingressnginx/annotations.go

0fd3ffc

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

give priority to temporal if both annotations are present

f9a7f93

Stevenjin8 reviewed Jan 29, 2026

View reviewed changes

pkg/i2gw/providers/ingressnginx/redirect_test.go Outdated Show resolved Hide resolved

jgreeer added 2 commits January 29, 2026 18:55

update copyright

e82e154

change test for both annotations case

6722897

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026

bexxmodd reviewed Feb 5, 2026

View reviewed changes

Merge branch 'main' into ingress-nginx/support-redirect

dead24e

jgreeer requested review from robscott and youngnick as code owners February 5, 2026 19:23

added check for port number

406cba4

Stevenjin8 mentioned this pull request Feb 6, 2026

feat: add support for from-to-www-redirect #337

Open

chakravardhan added a commit to chakravardhan/ingress2gateway that referenced this pull request Feb 6, 2026

fix(ingressnginx): remove force-ssl-redirect support and document com…

e76402b

…patibility with kubernetes-sigs#299

Stevenjin8 mentioned this pull request Feb 11, 2026

ingress2gateway 1.0 effort tracking issue #276

Open

kkk777-7 reviewed Feb 12, 2026

View reviewed changes

jgreeer added 7 commits February 12, 2026 16:11

Merge branch 'main' into ingress-nginx/support-redirect

c75b765

fixed backendrefs for redirect rule

00711fa

modify existing rule instead of creating a new one

f385e0b

replace full path as default

3346624

fix tests

a431c4e

lint

23bf2c9

iterate on all rules

5e76879

Conversation

jgreeer commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 9, 2026

Uh oh!

jgreeer commented Jan 15, 2026

Uh oh!

Stevenjin8 commented Jan 22, 2026

Uh oh!

jgreeer commented Jan 23, 2026

Uh oh!

Stevenjin8 commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stevenjin8 commented Feb 3, 2026

Uh oh!

k8s-ci-robot commented Feb 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgreeer commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jgreeer commented Jan 9, 2026 •

edited

Loading