[release-1.5] fix: use JoinHostPort#4646
Open
zirain wants to merge 2 commits intokubernetes-sigs:release-1.5from
Open
[release-1.5] fix: use JoinHostPort#4646zirain wants to merge 2 commits intokubernetes-sigs:release-1.5from
zirain wants to merge 2 commits intokubernetes-sigs:release-1.5from
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
size/S
Contributor
Author
|
cc @rikatz |
k8s-ci-robot
added
the
cncf-cla: yes
Merged
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mikemorris
suggested changes
Mar 6, 2026
Contributor
mikemorris
left a comment
mikemorris
left a comment
There was a problem hiding this comment.
One additional change to supercede (and avoid conflicting with) #4631
conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go
Outdated
Show resolved
Hide resolved
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zirain The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…ificate-validation.go Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>
k8s-ci-robot
removed
the
lgtm
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Manuall cherry-pick of #4636
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: