Ext proc refactor part three - Create and exploit the common Ext Proc server code base#2543
Open
shmuelk wants to merge 7 commits intokubernetes-sigs:mainfrom
Open
Ext proc refactor part three - Create and exploit the common Ext Proc server code base#2543shmuelk wants to merge 7 commits intokubernetes-sigs:mainfrom
shmuelk wants to merge 7 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
k8s-ci-robot
added
the
kind/cleanup
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shmuelk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Both the Endpoint Picker (EPP) and the Body Based Router (BBR) are Envoy ExtProc filters. There is much code that has been copy and pasted from one to the other.
This PR is the third in a series of PRs that will refactor out the common Ext Proc processing code into a set of reusable packages. This is being done to try and keep the PRs somewhat smaller.
This PR both "creates" the common Ext Proc server code base and exploits it for the EPP.
At this time the BBR code not yet exploit the new common Ext Proc server code base.
In particular this PR:
1. Moves the common Ext Proc code from pkg/epp/handlers to pkg/common/envoy/handlers
2. Adds the ServerHandler interface to provide a per request handler that deals with the EPP specific parts of the Ext Proc server.
3. Adds the ServerHandlerFactory interface used by the Ext Proc conmon code to create the per request ServerHandler instance.
4. Updates other parts of the code base due to the above changes
Which issue(s) this PR fixes:
Ref: #2427
Does this PR introduce a user-facing change?: