Skip to content

Docs: BBR guide fix#2541

Open
oshritf wants to merge 3 commits intokubernetes-sigs:mainfrom
oshritf:bbr_guide_fix
Open

Docs: BBR guide fix#2541
oshritf wants to merge 3 commits intokubernetes-sigs:mainfrom
oshritf:bbr_guide_fix

Conversation

@oshritf
Copy link

@oshritf oshritf commented Mar 10, 2026

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Allow users to properly and easily install multiple inference pools, fixes the guide to match deepseek/deepseek-r1 model and upates the Qwen config file manifest

Does this PR introduce a user-facing change?:

Serving multiple inference pools guide fixes

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 10, 2026
@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 38172e5
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69b05de6072afb0008bf3cfd
😎 Deploy Preview https://deploy-preview-2541--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oshritf
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 10, 2026

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @oshritf!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @oshritf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2026
@oshritf
Copy link
Author

oshritf commented Mar 10, 2026

@nirrozenbaum

Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshritf thanks for catching these typos.

there still seem to be some places where the model name is inconsistent, would be good if you could try out the guide end to end and verify we catch all those places.

additionally, you need to sign your commits :)

/ok-to-test

"deepseek-ai/DeepSeek-V3.2": "deepseek-ai/DeepSeek-V3.2",
"ski-resorts": "deepseek-ai/DeepSeek-V3.2",
"movie-critique": "deepseek-ai/DeepSeek-V3.2",
"deepseek/DeepSeek-r1": "deepseek/DeepSeek-r1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to be aligned with the sim-deployment:

- --model
- deepseek/vllm-deepseek-r1

can you update also sim deployment accordingly?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2026
@k8s-ci-robot
Copy link
Contributor

@oshritf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-test-e2e-main 38172e5 link true /test pull-gateway-api-inference-extension-test-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants