Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oshritf The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
Welcome @oshritf! |
|
Hi @oshritf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nirrozenbaum
left a comment
There was a problem hiding this comment.
@oshritf thanks for catching these typos.
there still seem to be some places where the model name is inconsistent, would be good if you could try out the guide end to end and verify we catch all those places.
additionally, you need to sign your commits :)
/ok-to-test
| "deepseek-ai/DeepSeek-V3.2": "deepseek-ai/DeepSeek-V3.2", | ||
| "ski-resorts": "deepseek-ai/DeepSeek-V3.2", | ||
| "movie-critique": "deepseek-ai/DeepSeek-V3.2", | ||
| "deepseek/DeepSeek-r1": "deepseek/DeepSeek-r1", |
There was a problem hiding this comment.
this doesn't seem to be aligned with the sim-deployment:
can you update also sim deployment accordingly?
|
@oshritf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Allow users to properly and easily install multiple inference pools, fixes the guide to match deepseek/deepseek-r1 model and upates the Qwen config file manifest
Does this PR introduce a user-facing change?: