Skip to content

feat: support multiple namespaces and namespace label selector filtering#6574

Open
Dasmat13 wants to merge 1 commit into
kubernetes-sigs:masterfrom
Dasmat13:feature/multi-namespace-support
Open

feat: support multiple namespaces and namespace label selector filtering#6574
Dasmat13 wants to merge 1 commit into
kubernetes-sigs:masterfrom
Dasmat13:feature/multi-namespace-support

Conversation

@Dasmat13

Copy link
Copy Markdown

Resolves #3565

Description

This PR introduces support for watching multiple namespaces and namespace label filtering for Service and Ingress sources.

Changes

  • Multiple Namespaces: Allows --namespace to accept a comma-separated list of namespaces.
  • Namespace Label Filter: Adds a new --namespace-label-filter flag to dynamically filter namespaces based on a label selector.
  • Dynamic Watch Scope: Automatically adjusts the informer namespace watch scope.
  • Event Throttling: Drops irrelevant namespace events to prevent unnecessary reconciliations.
  • Tests: Full unit test coverage included.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from u-kai and vflaux July 22, 2026 20:04
@kubernetes-prow kubernetes-prow Bot added apis Issues or PRs related to API change source labels Jul 22, 2026
@kubernetes-prow

Copy link
Copy Markdown

Welcome @Dasmat13!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @Dasmat13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2026
@Dasmat13

Copy link
Copy Markdown
Author

Hi @u-kai and @vflaux 👋

When you have a chance, could you please take a look at this PR? It also needs /ok-to-test before the required CI jobs can run.

The implementation adds support for watching multiple namespaces and namespace label selectors while keeping the existing single-namespace behavior intact. Happy to make any changes based on your feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apis Issues or PRs related to API change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple namespaces for Service sources

1 participant