Skip to content

docs(aws): correct hosted zone annotation prefix#6569

Open
immanuwell wants to merge 1 commit into
kubernetes-sigs:masterfrom
immanuwell:docs/aws-hosted-zone-id-prefix
Open

docs(aws): correct hosted zone annotation prefix#6569
immanuwell wants to merge 1 commit into
kubernetes-sigs:masterfrom
immanuwell:docs/aws-hosted-zone-id-prefix

Conversation

@immanuwell

@immanuwell immanuwell commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What does it do ?

Fixes the AWS hosted zone pin example. It now uses the default annotation prefix.

Motivation

The old alpha key is ignored by default, so overlapping zones still get every matching record

Repro: copy the old snippet to a Service or Ingress with same-name Route53 zones

Related: #6558

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: immanuwell <pchpr.00@list.ru>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @immanuwell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2026
@vflaux

vflaux commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Hi, it looks like we still have the old prefix in docs/annotations/annotations.md and docs/faq.md. Would you mind fixing those as well? Thanks.
/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29752321371

Coverage remained the same at 83.943%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 22065
Covered Lines: 18522
Line Coverage: 83.94%
Coverage Strength: 1412.1 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants