Skip to content

fix(ovh): add zone-match-parent for subdomain domain filters#6554

Open
dpacgdm wants to merge 1 commit into
kubernetes-sigs:masterfrom
dpacgdm:fix/ovh-zone-match-parent
Open

fix(ovh): add zone-match-parent for subdomain domain filters#6554
dpacgdm wants to merge 1 commit into
kubernetes-sigs:masterfrom
dpacgdm:fix/ovh-zone-match-parent

Conversation

@dpacgdm

@dpacgdm dpacgdm commented Jul 9, 2026

Copy link
Copy Markdown

Summary

  • Add --ovh-zone-match-parent (mirrors AWS --aws-zone-match-parent) so --domain-filter values that are subdomains of an OVH zone still select the parent zone.
  • Fixes the soft error where filters like pen-euw1-m.corp.com skipped OVH zone corp.com and records were never created.
  • Unit tests cover parent-zone matching; OVH tutorial and generated flags docs updated.

Related to #6458

Test plan

  • go test ./provider/ovh/ ./pkg/apis/externaldns/ -count=1
  • With OVH zones corp.com + other.com, run with --domain-filter=pen-euw1-m.corp.com --ovh-zone-match-parent and confirm corp.com is listed and records under the subdomain are created
  • Confirm default (flag off) still excludes parent zones for subdomain-only filters

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: dpacgdm / name: dpacgdm (eb07bb8)

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @dpacgdm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 9, 2026
@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added apis Issues or PRs related to API change docs provider Issues or PRs related to a provider labels Jul 9, 2026
Allow --domain-filter values that are subdomains of an OVH zone to
select the parent zone, matching AWS --aws-zone-match-parent behavior.
@dpacgdm
dpacgdm force-pushed the fix/ovh-zone-match-parent branch from 0779608 to eb07bb8 Compare July 10, 2026 05:56
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apis Issues or PRs related to API change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. provider Issues or PRs related to a provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant