fix(ovh): add zone-match-parent for subdomain domain filters#6554
fix(ovh): add zone-match-parent for subdomain domain filters#6554dpacgdm wants to merge 1 commit into
Conversation
|
|
|
Hi @dpacgdm. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Allow --domain-filter values that are subdomains of an OVH zone to select the parent zone, matching AWS --aws-zone-match-parent behavior.
0779608 to
eb07bb8
Compare
Summary
--ovh-zone-match-parent(mirrors AWS--aws-zone-match-parent) so--domain-filtervalues that are subdomains of an OVH zone still select the parent zone.pen-euw1-m.corp.comskipped OVH zonecorp.comand records were never created.Related to #6458
Test plan
go test ./provider/ovh/ ./pkg/apis/externaldns/ -count=1corp.com+other.com, run with--domain-filter=pen-euw1-m.corp.com --ovh-zone-match-parentand confirmcorp.comis listed and records under the subdomain are created