provider: add credential source boundary#6527
Conversation
Signed-off-by: YuMin Kim <gimyumin40@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @yuminn-k! |
|
Hi @yuminn-k. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Too early. I'm not sure about the approach |
What
SelectWithCredentialSourceat the provider factory boundary so future per-pipeline config can construct providers without mutating process env.Why
Follow-up slice from #6512 for the multi-provider CRD design in #1961. This establishes the credential boundary needed before wiring
credentialsRefinto pipeline construction.Notes
This does not wire CRD
credentialsRefyet. OCI workload identity, CoreDNS etcd env, and Scaleway SDK env handling are left as provider-specific follow-ups because they need different treatment than direct credential env reads.Validation
go test ./provider/credentials ./provider/factory ./provider/ns1 ./provider/civo ./provider/linode ./provider/gandi ./provider/cloudflare ./provider/dnsimplego test ./provider/...go test ./...PATH="$HOME/go/bin:$PATH" make lint