Skip to content

provider: add credential source boundary#6527

Draft
yuminn-k wants to merge 1 commit into
kubernetes-sigs:masterfrom
yuminn-k:codex/external-dns-credential-source
Draft

provider: add credential source boundary#6527
yuminn-k wants to merge 1 commit into
kubernetes-sigs:masterfrom
yuminn-k:codex/external-dns-credential-source

Conversation

@yuminn-k

@yuminn-k yuminn-k commented Jun 28, 2026

Copy link
Copy Markdown

What

  • Add a provider credential source abstraction with system-env and map-backed implementations.
  • Add SelectWithCredentialSource at the provider factory boundary so future per-pipeline config can construct providers without mutating process env.
  • Migrate Cloudflare, DNSimple, NS1, Civo, Gandi, and Linode provider construction to read credentials from the injected source while keeping existing env-backed behavior for current callers.
  • Add tests proving explicit sources do not fall back to global env and same-type providers can be constructed with distinct credentials.

Why

Follow-up slice from #6512 for the multi-provider CRD design in #1961. This establishes the credential boundary needed before wiring credentialsRef into pipeline construction.

Notes

This does not wire CRD credentialsRef yet. OCI workload identity, CoreDNS etcd env, and Scaleway SDK env handling are left as provider-specific follow-ups because they need different treatment than direct credential env reads.

Validation

  • go test ./provider/credentials ./provider/factory ./provider/ns1 ./provider/civo ./provider/linode ./provider/gandi ./provider/cloudflare ./provider/dnsimple
  • go test ./provider/...
  • go test ./...
  • PATH="$HOME/go/bin:$PATH" make lint

Signed-off-by: YuMin Kim <gimyumin40@gmail.com>
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vflaux for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the provider Issues or PRs related to a provider label Jun 28, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mloiseleur and u-kai June 28, 2026 06:06
@kubernetes-prow

Copy link
Copy Markdown

Welcome @yuminn-k!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @yuminn-k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2026
@ivankatliarchuk

Copy link
Copy Markdown
Member

Too early. I'm not sure about the approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants