Skip to content

[WIP] Refactor e2e tests to ginkgo framework#153

Open
Shilpa-Gokul wants to merge 1 commit intokubernetes-sigs:mainfrom
Shilpa-Gokul:e2e-test
Open

[WIP] Refactor e2e tests to ginkgo framework#153
Shilpa-Gokul wants to merge 1 commit intokubernetes-sigs:mainfrom
Shilpa-Gokul:e2e-test

Conversation

@Shilpa-Gokul
Copy link

@Shilpa-Gokul Shilpa-Gokul commented Feb 16, 2026

Partially fixes #145

This PR focuses on converting the bash based code in test/e2e/e2e.sh to ginkgo tests. make test-e2e command will now invoke the tests using ginkgo command.

Since this PR has already reached size XL, I’ve decided to move the pending items listed below to a follow-up PR to keep the review process manageable. Hope that's fine!

  • Change all the code in test/e2e/setup-e2e.sh and test/e2e/teardown-e2e.sh to ginkgo tests
  • Cleanup the existing bash based test scripts (e2e.sh, setup-e2e.sh, teardown-e2e.sh)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shilpa-Gokul
Once this PR has been reviewed and has the lgtm label, please assign elezar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @Shilpa-Gokul!

It looks like this is your first PR to kubernetes-sigs/dra-example-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-example-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2026
@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 2 times, most recently from c3fd93b to c585ef9 Compare February 16, 2026 13:20
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2026
@mortent mortent moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Feb 17, 2026
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2026
@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 4 times, most recently from d5f20c7 to 88c047e Compare February 19, 2026 06:32
Signed-off-by: Shilpa-Gokul <shilpagokul95@gmail.com>
@Shilpa-Gokul Shilpa-Gokul marked this pull request as ready for review February 19, 2026 07:10
@k8s-ci-robot k8s-ci-robot requested a review from pohly February 19, 2026 07:10
@Shilpa-Gokul
Copy link
Author

Looking forward to any feedback or comments on the implementation.

cc @nojnhuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor e2e tests into a real framework

2 participants

Comments