Skip to content

Remove vendoring and update tools for Go 1.25 compatibility#151

Open
chandramerla wants to merge 2 commits intokubernetes-sigs:mainfrom
chandramerla:fix-vendoring-tools
Open

Remove vendoring and update tools for Go 1.25 compatibility#151
chandramerla wants to merge 2 commits intokubernetes-sigs:mainfrom
chandramerla:fix-vendoring-tools

Conversation

@chandramerla
Copy link

@chandramerla chandramerla commented Feb 12, 2026

Fixes #147

  • Removes usage of go mod vendor from the Makefile and github workflows
  • Aligns hack/tools with the repository Go version
  • Updates tooling dependencies to build correctly with Go 1.25
  • Changed contextual logging as pre-existing contextual logging violations
    surfaced by newer tooling

Verified by running:

  • make build
  • make generate
  • make test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @chandramerla!

It looks like this is your first PR to kubernetes-sigs/dra-example-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-example-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chandramerla
Once this PR has been reviewed and has the lgtm label, please assign byako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 12, 2026
@marosset
Copy link

Please suggest if I should do log updates in separate PR:

I think it should be fine to update the logs in this PR.

@marosset
Copy link

@chandramerla - Can you remove the explicit go mod vendor calls from the github actions workflows in https://github.com/kubernetes-sigs/dra-example-driver/tree/main/.github/workflows as part of this PR?

@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Feb 18, 2026
Signed-off-by: chandramerla <Chandra.Merla@ibm.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2026
@chandramerla
Copy link
Author

@chandramerla - Can you remove the explicit go mod vendor calls from the github actions workflows in https://github.com/kubernetes-sigs/dra-example-driver/tree/main/.github/workflows as part of this PR?

Done

@chandramerla
Copy link
Author

Please suggest if I should do log updates in separate PR:

I think it should be fine to update the logs in this PR.

Thanks for the suggestion. I've add it here in this PR as a separate commit.

@chandramerla
Copy link
Author

@marosset Thanks Mark for the review. I've addressed your comments and push the changes.

Use klog.FromContext(ctx) and structured key-value logging in dra-example-kubeletplugin and dra-example-webhook. Pass request context into the admit handler for request-scope logging. Keep klog.Background() only at webhook startup.

Assisted-by: cursor
Signed-off-by: chandramerla <Chandra.Merla@ibm.com>
@chandramerla chandramerla marked this pull request as ready for review February 18, 2026 15:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@marosset
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scripts use go mod vendor but vendor directory isn't checked in

3 participants

Comments