Remove vendoring and update tools for Go 1.25 compatibility#151
Remove vendoring and update tools for Go 1.25 compatibility#151chandramerla wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
Welcome @chandramerla! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chandramerla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
I think it should be fine to update the logs in this PR. |
|
@chandramerla - Can you remove the explicit |
Signed-off-by: chandramerla <Chandra.Merla@ibm.com>
1f3460b to
36ab074
Compare
Done |
Thanks for the suggestion. I've add it here in this PR as a separate commit. |
|
@marosset Thanks Mark for the review. I've addressed your comments and push the changes. |
Use klog.FromContext(ctx) and structured key-value logging in dra-example-kubeletplugin and dra-example-webhook. Pass request context into the admit handler for request-scope logging. Keep klog.Background() only at webhook startup. Assisted-by: cursor Signed-off-by: chandramerla <Chandra.Merla@ibm.com>
12c8b7d to
2705a00
Compare
|
/ok-to-test |
Fixes #147
surfaced by newer tooling
Verified by running: