feat: implement Workspace Update API method#913
Open
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Open
feat: implement Workspace Update API method#913andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
andyatmiami wants to merge 1 commit intokubeflow:notebooks-v2from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/ok-to-test |
andyatmiami
force-pushed
the
feat/update-workspace-api-impl
branch
2 times, most recently
from
77be3c1 to
3650186
Compare
Contributor
Author
|
/hold need to refactor this a bit to leverage the additional validation abilities exposed in #905 |
andyatmiami
force-pushed
the
feat/update-workspace-api-impl
branch
2 times, most recently
from
0710184 to
21fce67
Compare
Contributor
Author
|
/unhold changes from #905 have been incorporated and an |
This commit delivers the following: - Complete the UpdateWorkspace repository method which was previously a stub (GH kubeflow#848). - Apply all mutable spec fields from the update model to the K8s Workspace object and persist via client.Update(). - Add handler tests for successful update, 409 stale revision, and 404 not found. Not included in this PR and to be addressed in a follow up: - Retrying on 409 response from k8s server to account for stale cache - TODO comment still in code calling out this need Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
andyatmiami
force-pushed
the
feat/update-workspace-api-impl
branch
from
21fce67 to
09e2ada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #848
This commit delivers the following:
Not included in this PR and to be addressed in a follow up: