Skip to content

chore: update net to v0.47.0 in pvcviewer-controller#790

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:notebooks-v1from
asaadbalum:782/fix-pvcviewer-golang-x-net-cve
Jan 15, 2026
Merged

chore: update net to v0.47.0 in pvcviewer-controller#790
google-oss-prow[bot] merged 1 commit intokubeflow:notebooks-v1from
asaadbalum:782/fix-pvcviewer-golang-x-net-cve

Conversation

@asaadbalum
Copy link

@asaadbalum asaadbalum commented Dec 9, 2025

Description

Update golang.org/x/net from v0.24.0 to v0.47.0 in the pvcviewer-controller to fix security vulnerabilities and align with other components (per reviewer feedback to match PR #786).

CVEs Fixed:

Related Issue: Closes #782 (PR 1)


Changes

Updated dependencies in components/pvcviewer-controller/go.mod:

Dependency Old Version New Version
golang.org/x/net v0.24.0 v0.47.0
golang.org/x/sys v0.19.0 v0.38.0
golang.org/x/term v0.19.0 v0.37.0
golang.org/x/text v0.14.0 v0.31.0
golang.org/x/tools v0.20.0 v0.38.0

Note: The additional golang.org/x/* packages are transitive dependencies of golang.org/x/net. They were automatically updated by go mod tidy to maintain compatibility.


Testing

Local Build & Tests

Test Result
go mod tidy ✅ Pass
go vet ./... ✅ No issues
make manager ✅ Builds cleanly
Unit tests (10/10) ✅ 65.4% coverage

CVE Verification (Trivy Scan)

=== Checking CVE-2025-22870 (x/net) ===
NOT FOUND - FIXED ✅

=== Checking CVE-2025-22872 (x/net) ===
NOT FOUND - FIXED ✅

=== Current golang.org/x/net version ===
golang.org/x/net v0.47.0 // indirect

Acceptance Criteria

  • Run go mod tidy to ensure dependencies are clean
  • Run make manager to build the controller
  • Run unit tests to verify functionality
  • CI workflows pass (unit, integration, multi-arch tests)
  • Deploy to notebooks-v1 cluster and verify PVCViewer component
  • Verify CVEs are fixed via Trivy scan

Signed-off-by: Asaad Balum asaad.balum@gmail.com

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Dec 9, 2025
@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Dec 9, 2025
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd December 9, 2025 08:20
@google-oss-prow google-oss-prow bot added the area/v1 area - version - kubeflow notebooks v1 label Dec 9, 2025
@asaadbalum asaadbalum marked this pull request as draft December 9, 2025 08:21
@google-oss-prow google-oss-prow bot requested a review from liavweiss December 9, 2025 08:41
@asaadbalum asaadbalum changed the title fix(pvcviewer-controller): update golang.org/x/net to v0.38.0 fix: update golang.org/x/net to v0.38.0 in pvcviewer-controller Dec 9, 2025
@asaadbalum asaadbalum force-pushed the 782/fix-pvcviewer-golang-x-net-cve branch from 1cb1b59 to dcfd8fb Compare December 9, 2025 09:08
@asaadbalum asaadbalum marked this pull request as ready for review December 9, 2025 09:46
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asaadbalum - sorry there has been a delay in reviewing this work.

appreciate you opening this to improve our security posture - but do you mind looking into this one (hopefully trivial) suggestion I have.

note that if incorporating my suggestion causes any issues/additional complexity - feel free to simply document why this isn't feasible and we can continue to get this merged as-is.

go.uber.org/multierr v1.11.0 // indirect
golang.org/x/exp v0.0.0-20240416160154-fe59bbe5cc7f // indirect
golang.org/x/net v0.24.0 // indirect
golang.org/x/net v0.38.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #786 is upgrading x/net to v0.47.0 - can we also upgrade to that version here to loosely try to keep versions aligned as we focus on dep upgrades?

I make this suggestion partly b/c in analyzing the deltas across 0.38.0 -> 0.47.0 - I don't see anything in the change logs that would make me think this is anything except a trivial update.

thanks!

@andyatmiami
Copy link
Contributor

/ok-to-test

Update golang.org/x/net from v0.24.0 to v0.47.0 in the pvcviewer-controller
to fix security vulnerabilities and align with other components.

CVEs Fixed:
- CVE-2025-22870
- CVE-2025-22872

Updated dependencies:
- golang.org/x/net v0.24.0 -> v0.47.0
- golang.org/x/sys v0.19.0 -> v0.38.0
- golang.org/x/term v0.19.0 -> v0.37.0
- golang.org/x/text v0.14.0 -> v0.31.0
- golang.org/x/tools v0.20.0 -> v0.38.0

Related Issue: Closes kubeflow#782 (PR 1)

Signed-off-by: Asaad Balum <asaad.balum@gmail.com>
@asaadbalum asaadbalum force-pushed the 782/fix-pvcviewer-golang-x-net-cve branch from dcfd8fb to 59b32f1 Compare January 13, 2026 14:21
@asaadbalum asaadbalum changed the title fix: update golang.org/x/net to v0.38.0 in pvcviewer-controller fix: update golang.org/x/net to v0.47.0 in pvcviewer-controller Jan 13, 2026
@asaadbalum
Copy link
Author

Thanks for the review @andyatmiami!

I've updated the PR to use golang.org/x/net v0.47.0 as suggested to align with PR #786.

Changes made:

  • Upgraded golang.org/x/net from v0.38.0 → v0.47.0
  • Transitive dependencies updated automatically via go mod tidy

Local verification:

  • go mod tidy - clean
  • make manager - builds successfully
  • ✅ Unit tests - 10/10 passed (65.4% coverage)
  • ✅ Trivy scan - CVE-2025-22870 and CVE-2025-22872 are fixed

Ready for another look!

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @asaadbalum for this contribution.

i independently confirmed the verification checks performed by the PR author are reproducible and valid.

furthermore, in analyzing the changes introduced across the significant version bumps of upgraded dependencies, I am comfortable with them being safe for our usage.

  • x/net: critical functional changes revolve around usage of html parsing and/or HTTP/2 server which doesn't apply to our usage

  • x/sys | x/term | x/text | x/tools : less controversial changes that reasonably verified by the application continuing to build

@google-oss-prow google-oss-prow bot added the lgtm label Jan 13, 2026
@thesuperzapper thesuperzapper changed the title fix: update golang.org/x/net to v0.47.0 in pvcviewer-controller chore: update golang.org/x/net to v0.47.0 in pvcviewer-controller Jan 15, 2026
@thesuperzapper thesuperzapper changed the title chore: update golang.org/x/net to v0.47.0 in pvcviewer-controller chore: update net to v0.47.0 in pvcviewer-controller Jan 15, 2026
@thesuperzapper
Copy link
Member

Thanks everyone, looks good.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 059e4e0 into kubeflow:notebooks-v1 Jan 15, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants