chore: update net to v0.47.0 in pvcviewer-controller#790
Conversation
1cb1b59 to
dcfd8fb
Compare
andyatmiami
left a comment
There was a problem hiding this comment.
Hey @asaadbalum - sorry there has been a delay in reviewing this work.
appreciate you opening this to improve our security posture - but do you mind looking into this one (hopefully trivial) suggestion I have.
note that if incorporating my suggestion causes any issues/additional complexity - feel free to simply document why this isn't feasible and we can continue to get this merged as-is.
| go.uber.org/multierr v1.11.0 // indirect | ||
| golang.org/x/exp v0.0.0-20240416160154-fe59bbe5cc7f // indirect | ||
| golang.org/x/net v0.24.0 // indirect | ||
| golang.org/x/net v0.38.0 // indirect |
There was a problem hiding this comment.
Given #786 is upgrading x/net to v0.47.0 - can we also upgrade to that version here to loosely try to keep versions aligned as we focus on dep upgrades?
I make this suggestion partly b/c in analyzing the deltas across 0.38.0 -> 0.47.0 - I don't see anything in the change logs that would make me think this is anything except a trivial update.
thanks!
|
/ok-to-test |
Update golang.org/x/net from v0.24.0 to v0.47.0 in the pvcviewer-controller to fix security vulnerabilities and align with other components. CVEs Fixed: - CVE-2025-22870 - CVE-2025-22872 Updated dependencies: - golang.org/x/net v0.24.0 -> v0.47.0 - golang.org/x/sys v0.19.0 -> v0.38.0 - golang.org/x/term v0.19.0 -> v0.37.0 - golang.org/x/text v0.14.0 -> v0.31.0 - golang.org/x/tools v0.20.0 -> v0.38.0 Related Issue: Closes kubeflow#782 (PR 1) Signed-off-by: Asaad Balum <asaad.balum@gmail.com>
dcfd8fb to
59b32f1
Compare
|
Thanks for the review @andyatmiami! I've updated the PR to use Changes made:
Local verification:
Ready for another look! |
andyatmiami
left a comment
There was a problem hiding this comment.
/lgtm
thanks @asaadbalum for this contribution.
i independently confirmed the verification checks performed by the PR author are reproducible and valid.
furthermore, in analyzing the changes introduced across the significant version bumps of upgraded dependencies, I am comfortable with them being safe for our usage.
-
x/net: critical functional changes revolve around usage of html parsing and/or HTTP/2 server which doesn't apply to our usage -
x/sys|x/term|x/text|x/tools: less controversial changes that reasonably verified by the application continuing to build
|
Thanks everyone, looks good. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update
golang.org/x/netfrom v0.24.0 to v0.47.0 in the pvcviewer-controller to fix security vulnerabilities and align with other components (per reviewer feedback to match PR #786).CVEs Fixed:
Related Issue: Closes #782 (PR 1)
Changes
Updated dependencies in
components/pvcviewer-controller/go.mod:golang.org/x/netgolang.org/x/sysgolang.org/x/termgolang.org/x/textgolang.org/x/toolsTesting
Local Build & Tests
go mod tidygo vet ./...make managerCVE Verification (Trivy Scan)
Acceptance Criteria
go mod tidyto ensure dependencies are cleanmake managerto build the controllerSigned-off-by: Asaad Balum asaad.balum@gmail.com