fix(run_kraken): replace bare except with proper error handling for kubecli init#1111
Open
AR21SM wants to merge 1 commit intokrkn-chaos:mainfrom
Open
fix(run_kraken): replace bare except with proper error handling for kubecli init#1111AR21SM wants to merge 1 commit intokrkn-chaos:mainfrom
AR21SM wants to merge 1 commit intokrkn-chaos:mainfrom
Conversation
…ubecli init Signed-off-by: AR21SM <mahajanashishar21sm@gmail.com>
Collaborator
|
@AR21SM Could you please provide a couple of screenshots of krkn falling in this use case with the input provided? Thank you very much |
Contributor
Author
Before: UnboundLocalError crash when kubecli is undefined After: Clean error message and exit
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix(run_kraken): replace bare except with proper error handling for kubecli init
Type of change
Description
The bare
exceptblock at line 173 attempted to callkubecli.initialize_clients(None), butkubecliis undefined at this point since the exception occurs during its initialization. This causes aNameErrorcrash on top of the original exception.Related Tickets & Documents
Documentation
No — this is an internal bug fix with no user-facing changes.
Checklist before requesting a review
REQUIRED:
Verified module imports cleanly:
This is a single-line fix for exception handling - no runtime test required as it only affects error path behavior.