Add test to `cerberus/setup.py` by iting0321 · Pull Request #1033 · krkn-chaos/krkn

iting0321 · 2025-12-31T08:41:12Z

Type of change

Refactor
New feature
Bug fix
Optimization

Description

Name                     Stmts   Miss  Cover   Missing
------------------------------------------------------
krkn/cerberus/setup.py      62      1    98%   127
------------------------------------------------------
TOTAL                       62      1    98%

Related Tickets & Documents

Related Issue Increase Testing Code Coverage #998
Closes #

Documentation

Is documentation needed for this update?

If checked, a documentation PR must be created and merged in the website repository.

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.

Copilot

Pull request overview

This PR adds comprehensive test coverage for the krkn/cerberus/setup.py module, improving code coverage from the current 98% to potentially 100%. The tests focus on three main functions: get_status, publish_kraken_status, and application_status, which handle Cerberus health monitoring and status reporting.

Adds 338 lines of unit tests covering various scenarios for Cerberus integration
Creates test package structure with proper initialization
Tests cover both healthy and unhealthy states, error conditions, and edge cases

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
tests/cerberus/test_setup.py	New comprehensive test suite for cerberus setup module with 3 test classes covering all major functions and edge cases
tests/cerberus/init.py	New package initialization file for cerberus test module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/cerberus/test_setup.py

Copilot · 2025-12-31T08:43:12Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_applicaton_routes": False


Spelling error: "applicaton" should be "application". This typo is consistent with the actual implementation code (line 17 in setup.py uses "check_applicaton_routes"), but it's still incorrect spelling.

tests/cerberus/test_setup.py

Copilot · 2025-12-31T08:43:12Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_applicaton_routes": True


Spelling error: "applicaton" should be "application". This typo is consistent with the actual implementation code (line 17 in setup.py uses "check_applicaton_routes"), but it's still incorrect spelling.

tests/cerberus/test_setup.py

tsebastiani · 2026-01-02T11:28:18Z

@iting0321 Thank you very much for your contributions, could you please solve the issues identified by copilot? Thanks a lot!

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-03T06:43:32Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_application_routes": True


The config dictionary uses check_application_routes but the actual source code uses check_applicaton_routes (with a typo - missing 'i'). This test will not accurately test the code path that checks application routes since the key doesn't match what the implementation looks for.

Copilot · 2026-01-03T06:43:32Z

tests/cerberus/test_setup.py

+        application_status("http://cerberus:8080", 0, 6000)
+
+        mock_exit.assert_called_once_with(1)


This test doesn't properly verify the behavior when sys.exit is called. The test should raise SystemExit but doesn't set up the mock to do so. Without mock_exit.side_effect = SystemExit(1), the test won't raise SystemExit and will just continue execution, making the assertion less meaningful.

Copilot · 2026-01-03T06:43:32Z

tests/cerberus/test_setup.py

+        application_status("http://cerberus:8080", 0, 6000)
+
+        mock_exit.assert_called_once_with(1)


This test doesn't properly verify the behavior when sys.exit is called. The test should raise SystemExit but doesn't set up the mock to do so. Without mock_exit.side_effect = SystemExit(1), the test won't raise SystemExit and will just continue execution, making the assertion less meaningful.

Copilot · 2026-01-03T06:43:32Z

tests/cerberus/test_setup.py

+        with patch('krkn.cerberus.setup.sys.exit') as mock_exit:
+            publish_kraken_status(config, ["failed_scenario"], 0, 100)
+            mock_exit.assert_called_once_with(1)


This test doesn't properly verify the sys.exit behavior. Without setting mock_exit.side_effect = SystemExit(1), the mock will prevent the actual SystemExit from being raised, making the test less meaningful. The test should either verify that exit was called or properly simulate the SystemExit exception.

Copilot · 2026-01-03T06:43:33Z

tests/cerberus/test_setup.py

+        with patch('krkn.cerberus.setup.sys.exit') as mock_exit:
+            publish_kraken_status(config, ["failed_scenario"], 0, 100)
+            mock_exit.assert_called_once_with(1)


This test doesn't properly verify the sys.exit behavior. Without setting mock_exit.side_effect = SystemExit(1), the mock will prevent the actual SystemExit from being raised, making the test less meaningful. The test should either verify that exit was called or properly simulate the SystemExit exception.

Copilot · 2026-01-03T06:43:33Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_application_routes": False


The config dictionary uses check_application_routes but the actual source code uses check_applicaton_routes (with a typo - missing 'i'). This test will not accurately test the code path that checks application routes since the key doesn't match what the implementation looks for.

Copilot · 2026-01-03T06:43:33Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_application_routes": True


The config dictionary uses check_application_routes but the actual source code uses check_applicaton_routes (with a typo - missing 'i'). This test will not accurately test the code path that checks application routes since the key doesn't match what the implementation looks for.

Copilot · 2026-01-03T06:43:34Z

tests/cerberus/test_setup.py

+        get_status(config, 0, 100)
+
+        mock_exit.assert_called_once_with(1)


This test doesn't properly verify the behavior when sys.exit is called. The test should raise SystemExit but doesn't set up the mock to do so. Without mock_exit.side_effect = SystemExit(1), the test won't raise SystemExit and will just continue execution, making the assertion meaningless.

Copilot · 2026-01-03T06:43:34Z

tests/cerberus/test_setup.py

+        get_status(config, 0, 100)
+
+        mock_exit.assert_called_once_with(1)


This test doesn't properly verify the behavior when sys.exit is called. The test should raise SystemExit but doesn't set up the mock to do so. Without mock_exit.side_effect = SystemExit(1), the test won't raise SystemExit and will just continue execution, making the assertion less meaningful.

Copilot · 2026-01-03T06:43:34Z

tests/cerberus/test_setup.py

+            "cerberus": {
+                "cerberus_enabled": True,
+                "cerberus_url": "http://cerberus:8080",
+                "check_application_routes": False


The config dictionary uses check_application_routes but the actual source code uses check_applicaton_routes (with a typo - missing 'i'). This test will not accurately test the code path that checks application routes since the key doesn't match what the implementation looks for.

iting0321 · 2026-01-03T07:06:34Z

Because “application” was misspelled as “applicaton” at line 17 in krkn/cerberus/setup.py, I opened pull request #1043.

…application routes

Fix the unittest for setup.py

45ad480

Copilot AI review requested due to automatic review settings December 31, 2025 08:41

iting0321 requested review from chaitanyaenr, paigerube14 and tsebastiani as code owners December 31, 2025 08:41

iting0321 mentioned this pull request Dec 31, 2025

Increase Testing Code Coverage #998

Closed

35 tasks

Copilot started reviewing on behalf of iting0321 December 31, 2025 08:41 View session

Copilot AI reviewed Dec 31, 2025

View reviewed changes

Fix the unittest

0221b47

tsebastiani added the pending discussions label Jan 2, 2026

Fix typo in 'check_application_routes' in TestGetStatus class

ff55fe7

Copilot AI review requested due to automatic review settings January 3, 2026 06:40

Copilot started reviewing on behalf of iting0321 January 3, 2026 06:41 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

Enhance tests to assert SystemExit for unhealthy cerberus status and …

c87e24c

…application routes

		application_status("http://cerberus:8080", 0, 6000)

		mock_exit.assert_called_once_with(1)

		get_status(config, 0, 100)

		mock_exit.assert_called_once_with(1)

Conversation

iting0321 commented Dec 31, 2025

Type of change

Description

Related Tickets & Documents

Documentation

Related Documentation PR (if applicable)

Checklist before requesting a review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tsebastiani commented Jan 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

iting0321 commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants