Skip to content

Small update to match/filter so regex flags can be passed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmachi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small update to match/filter so regex flags can be passed #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions js-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ exports.operators = {
});
return this;
},
match: filter(function(value, regex){
return new RegExp(regex).test(value);
match: filter(function(value, regex, flags){
return new RegExp(regex,flags).test(value);
}),
"in": filter(function(value, values){
return values.indexOf(value) > -1;
Expand Down Expand Up @@ -273,16 +273,17 @@ exports.operators = {
exports.filter = filter;
function filter(condition, not){
// convert to boolean right now
var filter = function(property, second){
var filter = function(property, second, options){
if(typeof second == "undefined"){
second = property;
property = undefined;
}

var args = arguments;
var filtered = [];
for(var i = 0, length = this.length; i < length; i++){
var item = this[i];
if(condition(evaluateProperty(item, property), second)){
if(condition(evaluateProperty(item, property), second, options)){
filtered.push(item);
}
}
Expand Down