fix wipe effect skipping frames when rendering takes "too long"#739
Open
vadosnaprimer wants to merge 4 commits intokraflab:masterfrom
Open
fix wipe effect skipping frames when rendering takes "too long"#739vadosnaprimer wants to merge 4 commits intokraflab:masterfrom
vadosnaprimer wants to merge 4 commits intokraflab:masterfrom
Conversation
Contributor
Author
|
I couldn't make In the future I might try making wipe last fixed time even if framerate changes. But making the pattern itself look consistent across settings is beyond my knowledge. |
41da88f to
9192c5e
Compare
software mode at high resolutions takes longer to render and to dump frames than opengl at comparable resolutions. so more real time passes between frames, which makes the ending advance the melt effect further than normal on the next frame. the code was always doing this, but it was written with much lower resolution in mind too, and viddump wasn't as widespread back then maybe? now melt consistently takes 45 frames, even tho in `wipe_doMelt()` cph says it takes 25 for some reason (that whole comment kinda contradicts current reality anyway). fixes kraflab#714
9192c5e to
52b5c13
Compare
Contributor
Author
|
Added interpolation for different framerates and heights. In some cases offsets become lower than 1 pixel, and if we want to stick to integer-only math we have to clamp it to 1 pixel. Those are rare cases tho, like framerates above 80 or resolutions lower than 320x200. reference.mp435.mp460.mp4144.mp4tiny.mp44k.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
software mode at high resolutions takes longer to render and to dump frames than opengl at comparable resolutions. so more real time passes between frames, which makes the ending advance the melt effect further than normal on the next frame.
the code was always doing this, but it was written with much lower resolution in mind too, and viddump wasn't as widespread back then maybe?
now melt consistently takes 45 frames, even tho in
wipe_doMelt()cph says it takes 25 for some reason (that whole comment kinda contradicts current reality anyway).fixes #714
Videos for comparison (software mode only, opengl looks similar but the pattern is slightly different):
320x240.mp4
2560x1440.mp4
3840x2160.mp4