Open
Conversation
Contributor
|
Hi @Covariance 👋🏻 Thanks for implementing this issue! It's a nice reference point for any future discussion 👌🏻 I've added a comment to the original issue on how I'd love to see this implemented in I could do this myself but I have limited capacity at this time. Feel free to follow the proposed plan in my comment if you would like to contribute this issue to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #385
I've done this one in the image and likeness of #319. However, this one actually changes the exposed interface, so I'm not sure whether I should change the
hlint.dhalland how. The same goes for the documentation as I'm not entirely sure what to put there.Also, as I assumed from the milestone, this would be introduced in 1.1.0.0, so I've placed the @SInCE tag accordingly.
EDIT: also, tests are not passing due to unsafe imports in the
Relude.Liftedand I'm not entirely sure what to do with that.Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.