fix: bump semconv from v1.39.0 to v1.40.0 in tracing.go - #1690
fix: bump semconv from v1.39.0 to v1.40.0 in tracing.go#1690ci-operator wants to merge 1 commit into
Conversation
|
🤖 Finished Review · ✅ Success · Started 5:36 PM UTC · Completed 5:42 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.50 |
|
Looks good to me Previous runLooks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
ready-for-merge
|
/rerun |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
+ Coverage 69.02% 74.94% +5.92%
==========================================
Files 74 74
Lines 10617 10617
==========================================
+ Hits 7328 7957 +629
+ Misses 2522 1912 -610
+ Partials 767 748 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Hi @ci-operator can you rebase on the latest |
Matches the schema version vendored otel/sdk uses internally, avoiding a resource.Merge conflict. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Josiah England <jengland@redhat.com>
68e1e58 to
93e8b9c
Compare
|
🤖 Finished Review · ✅ Success · Started 5:44 PM UTC · Completed 5:54 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.08 |
|
Risk Assessment: low (1/5) DetailsSingle-line semconv version bump in stable tracing module with zero churn, no protected paths, and no regression history. |
|
/ok-to-test |
|
/retest |
|
Scenario: konflux-e2e
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/integration-service:konflux-e2e-f5h2pTest results analysis🚨 Error occurred while running the E2E tests, list of failed Spec(s): ➡️ [ Click to view logsbuild pipelinerun fails for NameSpace/Application/Component stat-rep-xppu/integ-app-77i0/test-component-pac-l339hm with logs: Pipelinerun 'test-component-pac-l339hm-on-pull-request-qpqv8' didn't succeed
Expected success, but got an error:
<*errors.errorString | 0xc000e0c930>:
Pipelinerun 'test-component-pac-l339hm-on-pull-request-qpqv8' didn't succeed
{
s: "Pipelinerun 'test-component-pac-l339hm-on-pull-request-qpqv8' didn't succeed\n",
}➡️ [ Click to view logsUnexpected error:
<*fmt.wrapError | 0xc000d13ca0>:
fork of konflux-qe/konflux-test-integration to konflux-qe/konflux-test-integration-4gg7bp already exists but failed to fetch: The target couldn't be found.
{
msg: "fork of konflux-qe/konflux-test-integration to konflux-qe/konflux-test-integration-4gg7bp already exists but failed to fetch: The target couldn't be found.",
err: <*errors.errorString | 0xc000c3aa50>{
s: "The target couldn't be found.",
},
}
occurred➡️ [ Click to view logsExpected success, but got an error:
<*errors.errorString | 0xc00116a140>:
unable to retrigger pipelinerun for component group-5wgy:python-component-8ovj89: timed out waiting for new PipelineRun to appear after retriggering it for component group-5wgy:python-component-8ovj89
{
s: "unable to retrigger pipelinerun for component group-5wgy:python-component-8ovj89: timed out waiting for new PipelineRun to appear after retriggering it for component group-5wgy:python-component-8ovj89",
}➡️ [ Click to view logsExpected success, but got an error:
<*errors.errorString | 0xc0011673c0>:
error occurred while waiting for Integration PLR (associated with IntegrationTestScenario: integration-test-mcid) to NOT have the finalizer. Error: context deadline exceeded
{
s: "error occurred while waiting for Integration PLR (associated with IntegrationTestScenario: integration-test-mcid) to NOT have the finalizer. Error: context deadline exceeded",
}OCI Artifact Browser URL |
8 participants
A grpc dependency bump transitively moved otel/sdk to v1.43.0, which
uses semconv v1.40.0 internally. The schema mismatch made
resource.Merge fall back to resource.Default(), reporting service.name
as unknown_service:manager instead of integration-service. Bumping the
pin to v1.40.0 fixes it.
Maintainers will complete the following section