Extend test coverage for Nominatim importer and json reader and dumper#899
Merged
lonvia merged 3 commits intokomoot:masterfrom May 28, 2025
Merged
Extend test coverage for Nominatim importer and json reader and dumper#899lonvia merged 3 commits intokomoot:masterfrom
lonvia merged 3 commits intokomoot:masterfrom
Conversation
Also fixes handling of addr:place, which didn't yet follow the new address format.
Many of the tests are not meaningful anymore after switching to the new update method, so get rid of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports test harness around importers to assertj, making it easier to more extensively test result contents and adds more tests, especially around import of address data for a place. It also removes a lot of tests for the updater, which don't make sense anymore since the updater process switched to processing of change tables.
The new tests found a few issues with correct import of names, which have been fixed.