Use DatabaseProperties class to distribute import configuration to backend code#890
Merged
lonvia merged 4 commits intokomoot:masterfrom May 12, 2025
Merged
Use DatabaseProperties class to distribute import configuration to backend code#890lonvia merged 4 commits intokomoot:masterfrom
lonvia merged 4 commits intokomoot:masterfrom
Conversation
This makes the class directly usable with Jackson.
lonvia
added a commit
that referenced
this pull request
May 16, 2025
Fix accidental rename of version field in database #890 accidentally renamed the version field in the properties entry from 'databaseVersion' to 'version'. Revert that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are quite a few import settings now that need to be handed into the different classes. To stop the proliferation of function parameters, this changes the handling so that a DatabaseProperties instance functions as the global configuration container which is forwarded to whoever needs the configuration.