fix: Add `http.response.status_code` to mt-broker-ingress and imc-dispatcher metrics by creydr · Pull Request #8891 · knative/eventing

creydr · 2026-03-02T13:55:25Z

Adding the missing http.response.status_code attribute to the mt-broker-ingress and imc-dispatcher metrics

codecov · 2026-03-02T14:08:33Z

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.60%. Comparing base (ec13a36) to head (955c8a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/observability/newcontext.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8891      +/-   ##
==========================================
- Coverage   50.64%   50.60%   -0.04%     
==========================================
  Files         409      409              
  Lines       21650    21657       +7     
==========================================
- Hits        10964    10960       -4     
- Misses       9832     9843      +11     
  Partials      854      854

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cali0707

@creydr what do you think of putting the specifics of response status code metrics into a reusable function similar to

eventing/pkg/observability/newcontext.go

Lines 74 to 88 in ec13a36

    
           func WithRequestLabels(ctx context.Context, r *http.Request) context.Context { 
        
           	labeler, ok := otelhttp.LabelerFromContext(ctx) 
        
           	if !ok { 
        
           		ctx = otelhttp.ContextWithLabeler(ctx, labeler) 
        
           	} 
        
           	scheme := "http" 
        
           	if r.TLS != nil { 
        
           		scheme = "https" 
        
           	} 
        
           	labeler.Add(RequestScheme.With(scheme)) 
        
           	return ctx 
        
           }

? We could also clean up

eventing/pkg/broker/filter/filter_handler.go

Lines 510 to 514 in ec13a36

    
           dispatchInfo, err := h.eventDispatcher.SendEvent(ctx, *event, target, opts...) 
        
           labeler, _ := otelhttp.LabelerFromContext(ctx) 
        
           attrs := []attribute.KeyValue{semconv.HTTPResponseStatusCode(dispatchInfo.ResponseCode)} 
        
           attrs = append(attrs, labeler.Get()...) 
        
           h.dispatchDuration.Record(ctx, dispatchInfo.Duration.Seconds(), metric.WithAttributes(attrs...))

with this as well

creydr · 2026-03-02T14:37:00Z

@creydr what do you think of putting the specifics of response status code metrics into a reusable function similar to

eventing/pkg/observability/newcontext.go

Lines 74 to 88 in ec13a36

func WithRequestLabels(ctx context.Context, r *http.Request) context.Context {

labeler, ok := otelhttp.LabelerFromContext(ctx)

if !ok {

ctx = otelhttp.ContextWithLabeler(ctx, labeler)

}

scheme := "http"

if r.TLS != nil {

scheme = "https"

}

labeler.Add(RequestScheme.With(scheme))

return ctx

}

? We could also clean up

eventing/pkg/broker/filter/filter_handler.go

Lines 510 to 514 in ec13a36

dispatchInfo, err := h.eventDispatcher.SendEvent(ctx, *event, target, opts...)

labeler, _ := otelhttp.LabelerFromContext(ctx)

attrs := []attribute.KeyValue{semconv.HTTPResponseStatusCode(dispatchInfo.ResponseCode)}

attrs = append(attrs, labeler.Get()...)

h.dispatchDuration.Record(ctx, dispatchInfo.Duration.Seconds(), metric.WithAttributes(attrs...))

with this as well

Good point. Updated it

Cali0707 · 2026-03-02T14:44:31Z

@creydr

WARNING: DATA RACE
Write at 0x00c00006ad80 by goroutine 47:
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch.func1()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:319 +0x749
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch.gowrap1()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:330 +0x97

Previous read at 0x00c00006ad80 by goroutine 48:
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch.func1()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:328 +0xb4a
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch.gowrap1()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:330 +0x97

Goroutine 47 (running) created at:
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:311 +0x108
  knative.dev/eventing/pkg/channel/fanout.NewFanoutEventHandler.createEventReceiverFunction.func4()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:297 +0x13a
  knative.dev/eventing/pkg/channel.(*EventReceiver).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/event_receiver.go:335 +0x1aec
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:303 +0x58
  knative.dev/eventing/pkg/channel/multichannelfanout.(*EventHandler).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/multichannelfanout/multi_channel_fanout_event_handler.go:160 +0x3e1
  go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.(*middleware).serveHTTP()
      /home/runner/work/eventing/eventing/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:178 +0x2161
  go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.NewMiddleware.func1.1()
      /home/runner/work/eventing/eventing/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:66 +0x67
  net/http.HandlerFunc.ServeHTTP()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:2322 +0x47
  knative.dev/pkg/network/handlers.(*Drainer).ServeHTTP()
      /home/runner/work/eventing/eventing/vendor/knative.dev/pkg/network/handlers/drain.go:113 +0x1b9
  net/http.serverHandler.ServeHTTP()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:3340 +0x2a1
  net/http.(*conn).serve()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:2109 +0xda4
  net/http.(*Server).Serve.gowrap3()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:3493 +0x4f

Goroutine 48 (finished) created at:
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).dispatch()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:311 +0x108
  knative.dev/eventing/pkg/channel/fanout.NewFanoutEventHandler.createEventReceiverFunction.func4()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:297 +0x13a
  knative.dev/eventing/pkg/channel.(*EventReceiver).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/event_receiver.go:335 +0x1aec
  knative.dev/eventing/pkg/channel/fanout.(*FanoutEventHandler).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/fanout/fanout_event_handler.go:303 +0x58
  knative.dev/eventing/pkg/channel/multichannelfanout.(*EventHandler).ServeHTTP()
      /home/runner/work/eventing/eventing/pkg/channel/multichannelfanout/multi_channel_fanout_event_handler.go:160 +0x3e1
  go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.(*middleware).serveHTTP()
      /home/runner/work/eventing/eventing/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:178 +0x2161
  go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.NewMiddleware.func1.1()
      /home/runner/work/eventing/eventing/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:66 +0x67
  net/http.HandlerFunc.ServeHTTP()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:2322 +0x47
  knative.dev/pkg/network/handlers.(*Drainer).ServeHTTP()
      /home/runner/work/eventing/eventing/vendor/knative.dev/pkg/network/handlers/drain.go:113 +0x1b9
  net/http.serverHandler.ServeHTTP()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:3340 +0x2a1
  net/http.(*conn).serve()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:2109 +0xda4
  net/http.(*Server).Serve.gowrap3()
      /opt/hostedtoolcache/go/1.25.7/x64/src/net/http/server.go:3493 +0x4f

Cali0707

/lgtm
/approve

Thanks @creydr !

knative-prow · 2026-03-02T15:12:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Cali0707,creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

creydr added 2 commits March 2, 2026 14:50

fix: Add http.response.status_code to broker ingress metrics

dfbe4ab

fix: Add http.response.status_code to imc-dispatcher metrics

7be3aae

creydr requested review from Cali0707 and twoGiants March 2, 2026 13:55

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2026

knative-prow bot requested a review from matzew March 2, 2026 13:55

creydr changed the title ~~fix: Add http.response.status_code to mt-broker-ingress and imc-dispatcher metrics~~ fix: Add http.response.status_code to mt-broker-ingress and imc-dispatcher metrics Mar 2, 2026

add test

b80deaa

Cali0707 reviewed Mar 2, 2026

View reviewed changes

refactor: Extract HTTP status code label to helper function

b65352d

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2026

fix: Avoid data race in fanout handler metrics

955c8a7

creydr requested a review from Cali0707 March 2, 2026 15:05

Cali0707 approved these changes Mar 2, 2026

View reviewed changes

knative-prow bot assigned Cali0707 Mar 2, 2026

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026

knative-prow bot merged commit 223b43f into knative:main Mar 2, 2026
36 of 37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add `http.response.status_code` to mt-broker-ingress and imc-dispatcher metrics#8891

fix: Add `http.response.status_code` to mt-broker-ingress and imc-dispatcher metrics#8891
knative-prow[bot] merged 5 commits intoknative:mainfrom
creydr:add-status-code-attribute-to-mt-broker-ingress-metrics

creydr commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Cali0707 left a comment

Uh oh!

creydr commented Mar 2, 2026

Uh oh!

Cali0707 commented Mar 2, 2026

Uh oh!

Cali0707 left a comment

Uh oh!

knative-prow bot commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	func WithRequestLabels(ctx context.Context, r *http.Request) context.Context {
	labeler, ok := otelhttp.LabelerFromContext(ctx)
	if !ok {
	ctx = otelhttp.ContextWithLabeler(ctx, labeler)
	}

	scheme := "http"
	if r.TLS != nil {
	scheme = "https"
	}

	labeler.Add(RequestScheme.With(scheme))

	return ctx
	}

	dispatchInfo, err := h.eventDispatcher.SendEvent(ctx, *event, target, opts...)
	labeler, _ := otelhttp.LabelerFromContext(ctx)
	attrs := []attribute.KeyValue{semconv.HTTPResponseStatusCode(dispatchInfo.ResponseCode)}
	attrs = append(attrs, labeler.Get()...)
	h.dispatchDuration.Record(ctx, dispatchInfo.Duration.Seconds(), metric.WithAttributes(attrs...))

Conversation

creydr commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

creydr commented Mar 2, 2026

Uh oh!

Cali0707 commented Mar 2, 2026

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 2, 2026 •

edited

Loading