[release-1.20] fix: Remove duplicate OTEL observability setup in imc-dispatcher#8886
Merged
knative-prow[bot] merged 1 commit intoknative:release-1.20from Feb 24, 2026
Conversation
The imc-dispatcher was calling otel.SetupObservabilityOrDie in its NewController function, but sharedmain.MainWithContext already sets up observability before calling NewController. This caused Go runtime metrics to be registered twice, resulting in the error: "collected metric 'go_memory_allocations_total' was collected before with the same name and label values" This caused the metrics endpoint (/metrics) to fail with an error, preventing Prometheus from scraping metrics. Changes: - Use otel.GetMeterProvider() and otel.GetTracerProvider() to get the global providers already set up by sharedmain - Remove duplicate pprof server creation (sharedmain handles it) - Remove pprof config watch (sharedmain handles it) - Remove provider shutdown calls (sharedmain handles cleanup) - Clean up unused imports
knative-prow
bot
added
the
size/S
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.20 #8886 +/- ##
================================================
- Coverage 51.13% 51.12% -0.01%
================================================
Files 409 409
Lines 21356 21348 -8
================================================
- Hits 10920 10914 -6
+ Misses 9584 9583 -1
+ Partials 852 851 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8885