fix(eventing): suppress verbose OTEL logging in EventTransform by khushiiagrawal · Pull Request #8866 · knative/eventing

khushiiagrawal · 2026-01-28T12:43:10Z

Currently, when Eventing telemetry is enabled, the transform-jsonata component defaults to using the ConsoleSpanExporter. This causes verbose JSON trace data to be flooded into the container logs (stdout) instead of being sent to the configured OpenTelemetry collector. This makes the logs difficult to read and prevents traces from reaching the centralized monitoring system.

Proposed Changes

🐛 Fix bug

This PR updates the transform-jsonata deployment to properly configure the OpenTelemetry SDK for Node.js:

Injects Standard OTEL Config: Modified pkg/reconciler/eventtransform/resources_jsonata.go to generate standard OpenTelemetry environment variables (OTEL_EXPORTER_OTLP_TRACES_ENDPOINT, OTEL_EXPORTER_OTLP_PROTOCOL, OTEL_TRACES_SAMPLER, etc.) derived from the Knative config-observability map.
Enables Auto-Configuration: By passing these environment variables, the Node.js OTEL SDK in the container can now automatically detect the correct configuration and switch from the console exporter to the OTLP exporter, respecting the user's tracing endpoint and sampling settings.

Pre-review Checklist

At least 80% unit test coverage (Verified locally with new test cases)
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Fixed an issue where EventTransform components would log verbose OpenTelemetry traces to stdout instead of sending them to the configured tracing endpoint.

Docs

Signed-off-by: khushiiagrawal <khushisaritaagrawal@gmail.com>

linux-foundation-easycla · 2026-01-28T12:43:18Z

The committers listed above are authorized under a signed CLA.

✅ login: khushiiagrawal / name: Khushi Agrawal (32e1741, 6b7522b)

knative-prow · 2026-01-28T12:43:20Z

Welcome @khushiiagrawal! It looks like this is your first PR to knative/eventing 🎉

knative-prow · 2026-01-28T12:43:21Z

Hi @khushiiagrawal. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

khushiiagrawal · 2026-01-28T12:46:34Z

/retest

knative-prow · 2026-01-28T12:46:50Z

@khushiiagrawal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

khushiiagrawal · 2026-01-30T19:44:33Z

@Cali0707 @pierDipi @creydr Please take a look.
Appreciate your time.

khushiiagrawal · 2026-02-04T17:18:47Z

@creydr a gentle ping 😄

creydr · 2026-02-05T12:42:40Z

/ok-to-test
/cc @Cali0707

khushiiagrawal · 2026-02-06T20:30:46Z

@creydr all the tests have been passed, do let me know if any other changes required :)
Thanks!

khushiiagrawal · 2026-02-09T19:01:35Z

@Cali0707 could you please take a look once you get some time.
thanks a lot !

Cali0707

Thanks for working on this @khushiiagrawal - nice start!

I added some comments around changes I think we will need, and then this should be good to merge

Cali0707 · 2026-02-10T16:52:01Z

pkg/reconciler/eventtransform/resources_jsonata.go

+	// These are standard OpenTelemetry environment variables that the Node.js SDK
+	// automatically reads to configure the trace exporter.
+	OTELExporterEndpointEnv = "OTEL_EXPORTER_OTLP_TRACES_ENDPOINT"
+	OTELExporterProtocolEnv = "OTEL_EXPORTER_OTLP_PROTOCOL"


since we are setting the endpoint for just traces, let's also only specify the protocol for traces. Otherwise this will affect logs and metrics as well (without us providing an endpoint for those).

Suggested change

OTELExporterProtocolEnv = "OTEL_EXPORTER_OTLP_PROTOCOL"

OTELExporterProtocolEnv = "OTEL_EXPORTER_OTLP_TRACES_PROTOCOL"

Cali0707 · 2026-02-10T16:54:05Z

pkg/reconciler/eventtransform/resources_jsonata.go

+	}
+
+	// Configure sampling if a sampling rate is set
+	if tracingCfg.SamplingRate > 0 {


maybe handle the case where tracingCfg.SamplingRate == 0 - in thise case we would want the sampler to be set to always_off

let's also check when SamplingRate == 1, as then we would want always_on, to avoid the extra computations of sampling and preserve expected semantics from the config

Cali0707 · 2026-02-10T16:55:22Z

pkg/reconciler/eventtransform/resources_jsonata.go

+								append(
+									[]corev1.EnvVar{
+										{
+											Name:  "JSONATA_TRANSFORM_FILE_NAME",
+											Value: filepath.Join(JsonataExpressionPath, JsonataExpressionDataKey),
+										},
 									},
-								},
-								cw.ToEnvVars()...,
+									cw.ToEnvVars()...,
+								),
+								otelTracingEnvVars(cw)...,


let's add some test cases to eventtransform_test.go that verify that the env vars are set correctly on the deployment

Cali0707 · 2026-02-10T16:57:46Z

pkg/reconciler/eventtransform/resources_jsonata.go

-									{
-										Name:  "JSONATA_TRANSFORM_FILE_NAME",
-										Value: filepath.Join(JsonataExpressionPath, JsonataExpressionDataKey),
+								append(


Can you try to refactor this somehow? Having two nested appends here is somewhat hard to read.

…onata deployment Signed-off-by: khushiiagrawal <khushisaritaagrawal@gmail.com>

knative-prow · 2026-02-13T13:15:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khushiiagrawal
Once this PR has been reviewed and has the lgtm label, please ask for approval from cali0707. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

khushiiagrawal · 2026-02-13T13:16:42Z

@Cali0707 thank you so much for the review. i have addressed all the changes, please take a look.
thanks!

khushiiagrawal · 2026-02-19T19:48:18Z

@Cali0707 a gentle ping 😄

fix(eventing): suppress verbose OTEL logging in EventTransform

32e1741

Signed-off-by: khushiiagrawal <khushisaritaagrawal@gmail.com>

knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2026

knative-prow bot requested review from Cali0707 and pierDipi January 28, 2026 12:43

Cali0707 requested a review from creydr January 28, 2026 13:49

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2026

Cali0707 requested changes Feb 10, 2026

View reviewed changes

knative-prow bot assigned Cali0707 Feb 10, 2026

Implement tests for OpenTelemetry tracing environment variables in Js…

6b7522b

…onata deployment Signed-off-by: khushiiagrawal <khushisaritaagrawal@gmail.com>

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2026

	OTELExporterProtocolEnv = "OTEL_EXPORTER_OTLP_PROTOCOL"
	OTELExporterProtocolEnv = "OTEL_EXPORTER_OTLP_TRACES_PROTOCOL"

Conversation

khushiiagrawal commented Jan 28, 2026

Proposed Changes

Pre-review Checklist

Uh oh!

linux-foundation-easycla bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knative-prow bot commented Jan 28, 2026

Uh oh!

knative-prow bot commented Jan 28, 2026

Uh oh!

khushiiagrawal commented Jan 28, 2026

Uh oh!

knative-prow bot commented Jan 28, 2026

Uh oh!

khushiiagrawal commented Jan 30, 2026

Uh oh!

khushiiagrawal commented Feb 4, 2026

Uh oh!

creydr commented Feb 5, 2026

Uh oh!

khushiiagrawal commented Feb 6, 2026

Uh oh!

khushiiagrawal commented Feb 9, 2026

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

Cali0707 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Cali0707 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Cali0707 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Cali0707 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Cali0707 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Feb 13, 2026

Uh oh!

khushiiagrawal commented Feb 13, 2026

Uh oh!

khushiiagrawal commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

linux-foundation-easycla bot commented Jan 28, 2026 •

edited

Loading