Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct by matzew · Pull Request #8448 · knative/eventing

matzew · 2025-02-10T13:18:55Z

Fixes #

Proposed Changes

as per title

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Docs

test/e2e-common.sh

creydr

/lgtm

matzew · 2025-02-10T14:28:22Z

/hold
I will clean the unit tests 🪐

…audience to ensure the camel containers work correct Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

codecov · 2025-02-10T15:10:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (4a6e7d2) to head (519a7a1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8448      +/-   ##
==========================================
- Coverage   64.10%   64.09%   -0.01%     
==========================================
  Files         388      388              
  Lines       23363    23365       +2     
==========================================
- Hits        14976    14975       -1     
- Misses       7591     7593       +2     
- Partials      796      797       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr

/lgtm

knative-prow · 2025-02-10T15:49:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [creydr,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

creydr · 2025-02-10T15:49:15Z

Unit tests seem to be fixed
/hold cancel

matzew · 2025-02-13T06:37:08Z

/cherry-pick release-1.17

knative-prow-robot · 2025-02-13T06:37:46Z

@matzew: new pull request created: #8459

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…audience to ensure the camel containers work correct (knative#8448) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* IntegrationSource CRD (knative#8238) * Add initial raw API types and controller/reconciler. Levering internally the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved. Tests/lifeccyle and some other improvements are still missing. but this works. Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * adding reflection to make the mapping less verbose, and more flexible to extend... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add DDB Streams Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * polish and add minimal tests Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Fix compiler warnings Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * use other image coordinates Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * first test for source Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding initial rekt test Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding SSL support and test for IntegrationSource Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Formatting fixes Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Disable OIDC tests for now Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * use knative nightly images Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Fixing linters Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * addressing comments, Part1 Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Add missing copyright boilerplate (knative#8305) :lipstick: add missing copyright boilerplate Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * [chore] Use a generic access/secret key in the secret for AWS connections (knative#8312) :key: Use a generic access/secret key in the secret for AWS connections Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * [chore] Do not generate SSL env vars for each struct entry, just once per containersource/image (knative#8315) :lipstick: Do not generate SSL env vars for each struct entry, just once per containersource/image Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update Integration API and use custom tags on structs for better readability (knative#8321) Update API and use custom tags on structs Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Integration Api moved to versioned common (knative#8325) Moving API to a versioned common/integration folder Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Introducing common integration helper and change package name (knative#8327) * create new integration/source folder and factor common code into helper.go Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 💄 improve formatting... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fixing import Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * chore: correct comments (knative#8336) :lipstick: correct comments ... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add IntegrationSink CRD (knative#8304) * create new integration/source folder and factor common code into helper.go Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 💄 improve formatting... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fixing import Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * First Sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Updates on sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * starting common types for source Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * starting common types for sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * some code share and refactorings * use other image coordinates Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add missing api and tests for sink and run codegen Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Fixes Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding cert Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding test Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Rekt test for sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Rekt test for sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * correct status code Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * More... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * re-add service Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * delete unversioned common api Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Updates, latest conflicts and formatting Clean ups Adding tests for reconciler Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> conflict Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * IntegrationSink: rek-test templating support for bool annotations (knative#8342) bool annotations for represented as string, to avoid parsing errors Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update integrationsink crd (knative#8347) * Align IntegrationSink CRD w/ IntegrationSource CRD Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 💄 Remove old job-sink references Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Docs change Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Avoid using twice hardcoded strings for the names of the Kube Secret keys, for AWS access/secret key vals (knative#8345) :lipstick: Avoid using twice hardcoded strings for the names of the Kubescret keys, for AWS access/secret key vals Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add integrationsinks-addressable-resolver cluster role (knative#8356) :passport_control: Add integrationsinks-addressable-resolver cluster role Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Align label generation and apply on container-source as well (knative#8355) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * We changed the event type on the images (knative#8364) :fire: We changed the event type on the images Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Move image to map (knative#8362) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding sns sink to Integration Sink (knative#8365) adding sns sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Clean up remove session token (knative#8369) Remove session token and profile credential name Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Chore: field semantic correction (knative#8370) :lipstick: We renamed those fields to , and we reflect that now in validation Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Remove unused filter function (knative#8375) :broom: Remove unused filter function Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * add new integration CRDs to storage version migrator tool (knative#8386) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Going OIDC for Integration Source (knative#8383) Going OIDC for Integration Source: - Generating OIDC specific evn_vars for Knative client of camel - Adding rekt-test for OIDC feature of the source Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding reconciler test for OIDC of the Integration Source (knative#8404) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct (knative#8448) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * run `make generate-release` --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com>

…audience to ensure the camel containers work correct (knative#8448) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

…audience to ensure the camel containers work correct (knative#8448) (#1079) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Feb 10, 2025

knative-prow bot requested review from aliok and mgencur February 10, 2025 13:18

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2025

creydr reviewed Feb 10, 2025

View reviewed changes

test/e2e-common.sh Outdated Show resolved Hide resolved

matzew force-pushed the enable_oidc_if_cfg_and_audience_is_set branch from 6a84d3b to 5a8cf40 Compare February 10, 2025 13:36

creydr approved these changes Feb 10, 2025

View reviewed changes

knative-prow bot assigned creydr Feb 10, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025

Not just render oidc env-vars when cfg is on, we need also a present …

519a7a1

…audience to ensure the camel containers work correct Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew force-pushed the enable_oidc_if_cfg_and_audience_is_set branch from 5a8cf40 to 519a7a1 Compare February 10, 2025 15:04

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2025

creydr approved these changes Feb 10, 2025

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025

knative-prow bot merged commit 162575c into knative:main Feb 10, 2025
35 of 36 checks passed

knative-prow-robot mentioned this pull request Feb 13, 2025

[release-1.17] Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct #8459

Merged

creydr mentioned this pull request May 22, 2025

TestIntegrationSourceWithTLS fail when OIDC is enabled, but sink has no audience set knative-extensions/eventing-integrations#63

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct#8448

Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct#8448
knative-prow[bot] merged 1 commit intoknative:mainfrom
matzew:enable_oidc_if_cfg_and_audience_is_set

matzew commented Feb 10, 2025

Uh oh!

Uh oh!

creydr left a comment

Uh oh!

matzew commented Feb 10, 2025

Uh oh!

codecov bot commented Feb 10, 2025 •

edited

Loading

Uh oh!

creydr left a comment

Uh oh!

knative-prow bot commented Feb 10, 2025

Uh oh!

creydr commented Feb 10, 2025

Uh oh!

Uh oh!

matzew commented Feb 13, 2025

Uh oh!

knative-prow-robot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matzew commented Feb 10, 2025

Proposed Changes

Pre-review Checklist

Uh oh!

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

matzew commented Feb 10, 2025

Uh oh!

codecov bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Feb 10, 2025

Uh oh!

creydr commented Feb 10, 2025

Uh oh!

Uh oh!

matzew commented Feb 13, 2025

Uh oh!

knative-prow-robot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 10, 2025 •

edited

Loading