Conversation
merged with forked repo
add dataplane functionality to RequestReply
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
|
Welcome @vichekaoeun! It looks like this is your first PR to knative/eventing 🎉 |
knative-prow
bot
added
needs-ok-to-test
|
Hi @vichekaoeun. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Cali0707
left a comment
Cali0707
left a comment
There was a problem hiding this comment.
Nice start @vichekaoeun ! Let me know if you have any questions while you work on this
| @@ -0,0 +1,143 @@ | |||
| package main | |||
There was a problem hiding this comment.
This file should be moved to cmd/requestreply/dataplane/main.go
| fmt.Printf("handling new event: %s\n", event.String()) | ||
|
|
||
| originalID := event.ID() //generate signed id using event id | ||
| signedID := originalID + "_signed" //placeholder for signing |
There was a problem hiding this comment.
Here we should do the actual signing. We likely want to make a helper function like https://github.com/d3akhtar/eventing/blob/fefc79aa7d37180e6f67b6dde8ac0982e9f3ce5e/pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go#L214-L227, except instead of decrypting the signed data, we want to encrypt it.
|
|
||
| responseWriter.WriteHeader(http.StatusAccepted) | ||
|
|
||
| id := event.Extensions()["replyAttribute"] //check if event has replyAttribute |
There was a problem hiding this comment.
The name of the cloud event extension which we access should be an environment variable, for example CE_REPLY_ATTRIBUTE_NAME
| responseWriter: responseWriter, | ||
| replyEvent: make(chan *cloudevents.Event, 1), | ||
| } | ||
| m.entries[id] = pr |
There was a problem hiding this comment.
Instead of id, we should be using the id + signed id attribute from the relevant cloudevent extension attribute (accessed using the env var).
merge with upstream
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vichekaoeun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…reply-dataplane merge other branch to this
|
@pierDipi could you have a look at my changes? |
|
This Pull Request is stale because it has been open for 90 days with |
github-actions
bot
added
the
lifecycle/stale
2 participants
Made some changes for the dataplane to include attribute check and timeout check
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs