Skip to content

[release-1.16] fix: remove duplicated observedGeneration from jobsinks.sinks.knative.dev#8423

Merged
knative-prow[bot] merged 1 commit intoknative:release-1.16from
knative-prow-robot:cherry-pick-8326-to-release-1.16
Jan 22, 2025
Merged

[release-1.16] fix: remove duplicated observedGeneration from jobsinks.sinks.knative.dev#8423
knative-prow[bot] merged 1 commit intoknative:release-1.16from
knative-prow-robot:cherry-pick-8326-to-release-1.16

Conversation

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Jan 22, 2025

This is an automated cherry-pick of #8326

Fixes #8412

@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi January 22, 2025 16:26
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.95%. Comparing base (bb92b8c) to head (f3ed858).
Report is 2 commits behind head on release-1.16.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16    #8423   +/-   ##
=============================================
  Coverage         64.95%   64.95%           
=============================================
  Files               359      359           
  Lines             22061    22061           
=============================================
  Hits              14330    14330           
  Misses             6979     6979           
  Partials            752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@knative-prow
Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@knative-prow knative-prow bot merged commit 7289df9 into knative:release-1.16 Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants