x86_64: Use ud2 instruction as reboot method#321
Open
vl-prokopenko wants to merge 1 commit intoklange:masterfrom
Open
x86_64: Use ud2 instruction as reboot method#321vl-prokopenko wants to merge 1 commit intoklange:masterfrom
vl-prokopenko wants to merge 1 commit intoklange:masterfrom
Conversation
Owner
|
Are you actually experiencing a failure to reboot that this resolves? Since we're already loading an empty IDT, plenty of other things are effectively guaranteed to happen, such as the local timer interrupt. |
Author
|
I don't. I simply believe this is a cleaner and faster way to reboot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more reliable on modern hardware than a keyboard reset. Using the ud2 instruction without an IDT is almost guaranteed to cause a triple fault and a "keyboard reset" is not, and is also way simpler. The keyboard reset and return methods are included as fallback, even though they're unlikely to be used.