Add OpenHydroponics input module#1416
Draft
mickeprag wants to merge 11 commits intokizniche:masterfrom
Draft
Conversation
On some platforms (Armbian) this may be a ramdisk and recreated at each boot
These functions can be used as helpers when working with asyncio
mickeprag
force-pushed
the
openhydroponics
branch
from
cf21d9e to
6fcbf6c
Compare
Owner
|
This failed the test. It will need to have the import handled differently so it can pass the test. |
Author
|
I will have a look at the tests. I put this as a draft since I just want to know if I am on the right track. |
Owner
|
Ah, I didn't notice the draft. I'm that case, yes, it looks very good. The tests can be run locally to test if they pass. The following will run all tests: cd /opt/Mycodo/mycodo You can add this to run a specific test and save time: -k 'specific_test_name' |
Author
|
I think I solved the test issue. Could you run the CI testing again, please? |
Author
|
Ok, still errors. But at least another error this time... |
mickeprag
force-pushed
the
openhydroponics
branch
from
1fdf142 to
8a8e9ba
Compare
This happens during testing
mickeprag
force-pushed
the
openhydroponics
branch
from
8a8e9ba to
c33fafd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.