Merged
Conversation
Fixes kislyuk#535 This checks if the interpreter is anything with python or pypy in it. Thus, avoiding executing e.g. `php -m argcomplete._check_console_script ...` (which succeeds).
Contributor
Author
|
I can attempt to write a test for this, however, not today. |
Owner
|
Thank you! |
Contributor
Author
I attempted to create a script with a shebang that passes even with the Such script can then be used like this: def test_foreign_scripts_not_broken(self):
self.sh.run_command("cd " + TEST_DIR)
self.sh.run_command("complete -W 'hello' echoer")
self.sh.run_command(TestBashZshGlobalBase.install_cmd)
self.assertTrue(self.sh.run_command("echoer h\t").endswith("echoer hello\r\n"))However, I am not able to make it fail without the fix, so it is not useful as a test :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535
This checks if the interpreter is anything with python or pypy in it.
Thus, avoiding executing e.g.
php -m argcomplete._check_console_script ...(which succeeds).