Add support for offsets on top and bottom boundary supplementary views - #122
Open
CallMeSH wants to merge 2 commits into
Open
Add support for offsets on top and bottom boundary supplementary views#122CallMeSH wants to merge 2 commits into
CallMeSH wants to merge 2 commits into
Conversation
|
If two headers are provided still works incorrectly... places both headers at maximum extendedHeight instead firstCell top absolute offset calculations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support for offsetting top and bottom boundary supplementary views.
I didn't need leading and trailing cases so I didn't try to implement them.
I might do it later if I find some time.
I'm still not 100% comfortable with the code base so if I'm sorry if I added my code in the wrong place.
I hope this will be useful 👍
Fixes top and bottom cases for #121