Add kirbyXComboboxItemTemplate directive with clear documentation - #4519
Open
HootERasmus wants to merge 9 commits into
Open
Add kirbyXComboboxItemTemplate directive with clear documentation#4519HootERasmus wants to merge 9 commits into
HootERasmus wants to merge 9 commits into
Conversation
HootERasmus
marked this pull request as ready for review
June 8, 2026 13:31
Collaborator
|
ListItemTemplate is also marked as standalone and should be imported directly where needed. |
Fuzzy3
requested changes
Aug 25, 2026
Fuzzy3
left a comment
Collaborator
There was a problem hiding this comment.
Nice ! I have one comment about adding an "X" to the template name, and then I'd like if we could update the storybook documentation, such that it is very clear that this template directive is needed.
Also the title and description should be updated in this PR to reflect the solution 🤓
- Renamed template directive from kirbyComboboxItemTemplate to kirbyXComboboxItemTemplate - Updated storybook stories to use the new directive name - Added prominent documentation in WithTemplate, CustomSearchFunction, and LargeList stories - Enhanced JSDoc comments to clarify that the directive is required for custom item templates - All examples now clearly show the *kirbyXComboboxItemTemplate syntax on kirby-item elements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #4518
What is the new behavior?
Added
kirbyXComboboxItemTemplatedirective to enable custom item templating in the Combobox component. This directive provides context variables (item,selected,focused) for templated items and must be applied to thekirby-itemelement when using custom templates.The directive follows the naming convention of prefixing with 'X' (like
kirby-x-combobox), and comprehensive storybook documentation has been added to make it clear when and how to use this directive.Does this PR introduce a breaking change?
Key Changes
kirbyXComboboxItemTemplatefor consistencyWithTemplate,CustomSearchFunction,LargeList) to demonstrate the directive usageChecklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.