入力値チェックプラグインのjQuery削除 - #231
Merged
ashinohito merged 4 commits intoJun 5, 2026
Merged
Conversation
Contributor
README.md の OSS ライセンス一覧についてjQuery 剥がしに伴い、 1. jQuery の記載を削除してください(今回の対応漏れ) jQuery を剥がしたため不要になっていますが、記載が残っています。 2. KintoneRestAPIClient の記載を追加してください これは今回の変更で入ったものではなく元からの記載漏れですが、 (なお |
Contributor
|
(横から追記失礼します🙇♀️)
|
Contributor
|
README の対応ありがとうございます。1点だけ追加でお願いします。 JsRender のバージョン表記の不整合
|
Contributor
|
@ashinohito さんのご指摘分もあわせて対応確認しました。
私からの README の指摘分もすべて対応済みです。マージOKです。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery依存を削除しました。
また、document.addEventListener('DOMContentLoaded', ...) が発火しなかっため、
以下のようにreadyStateを判定して初期化処理を実行するよう修正しました。