API Refactoring - v2.0#632
Open
ppaquette wants to merge 1 commit intokestasjk:masterfrom
Open
Conversation
- Added API key permission 'canReplaceUsersInCD' - Added game property 'allowBotCDOrdering' that can be configured on the create game page - Added route 'game/message' to send game messages - Added route 'game/ready' to change the wait/ready flag - Added route 'game/vote' to vote on draw, pause, cancel, concede - Added route 'players/my_games' to filter games based on criteria - Refactored the API permission on a more granular level - Improved the logic for allowing bots to submit orders for users in civil disorder
Contributor
|
Oh wow, didn't realize a press version was near. It'll take me some time to look through all this. So your suggestion of a couple weeks is good timing wise lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kestasjk @jmo1121109
For your comments.
This is a more substantial API refactoring that fixes most of the current issues.
We should probably wait a couple of weeks before merging this, to make sure everything works properly first. I wanted to do it while I still had the API specification clear in my mind.
The corresponding python PR is at here PR 96.
A game needs to meet all the following conditions to be eligible for CD ordering:
validateRoutemethod to check for permissionsBuilding a mobile app should also be much easier with this API, since most of the core functionalities are supported (except create_game, find_games, join_game).