Mixed bag of fixes mostly for RPi4 #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity scan detected a memory leak in the new firewall change() cb where allocated memory from ietf_interfaces_get_all_l3() was not freed on error paths when srx_get_diff() failed or returned NULL. This commit consolidates all cleanup paths to use the 'done:' label, ensuring ifaces, diff, and cfg are properly freed in all exit scenarios. Signed-off-by: Joachim Wiberg <[email protected]>
Fixes a minor regression after merge of BPi-R3. The RPi4 device tree, specifically regulator-sd-io-1v8 in bcm2711-rpi-4-b.dts, requires the GPIO voltage regulator be built-in for the SD card controller. Fixes #1197 Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Fixes #1194 Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
The curl.sh wrapper script had several issues: - Used 'shift 2' incorrectly without proper argument validation - Required hostname as enviroment variable instead of option - Lacked proper option parsing, should behave like a cross between curl and sysrepocfg All examples have been updated to match the refactored script, and a local copy in utils/curl.sh has been added. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
mattiaswal
approved these changes
Oct 14, 2025
Contributor
mattiaswal
left a comment
mattiaswal
left a comment
There was a problem hiding this comment.
LGTM 👍 to have RPI booting again is a good feature 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
genimage.cfgmkimage.shscript to ease sdcard generationChecklist
Tick relevant boxes, this PR is-a or has-a: