Skip to content

refactor/chart refactor - #2055

Open
alanpeixinho wants to merge 2 commits into
kernelci:mainfrom
profusion:refactor/chart-refactor
Open

refactor/chart refactor#2055
alanpeixinho wants to merge 2 commits into
kernelci:mainfrom
profusion:refactor/chart-refactor

Conversation

@alanpeixinho

Copy link
Copy Markdown
Contributor

What it is

Status pie center text uses a CSS overlay; dead chart props/UI removed.
History chart Y-axis ticks no longer overlap; current commit uses ChartsReferenceLine.
Legend is Success / Failed / Inconclusive; unused locale strings dropped.
Closes #40

How to test

  • Status pie: label/count centered in donut; legend click still filters
  • History chart: Y labels clear of the axis; dashed blue line on current commit
  • Legend labels are generic (not build/boot/test-specific)
  • Check small and large screen layouts

Use table-fixed layout with string-based path width and horizontal scroll
so columns stay stable while sorting, paginating, and virtualizing rows.
Add prefix ellipsis for long paths, 12px tree indent, and group lab
summaries matching hardware (count when mixed).

Closes kernelci#420

Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
- Center status pie text via CSS overlay; drop dead chart props
- Fix history Y-axis overlap; mark current commit with ChartsReferenceLine
- Use Success/Failed/Inconclusive legend; remove unused locales

Closes kernelci#40

@felipebergamin felipebergamin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

Something I noticed while testing your PR is this horizontal scroll on tabs when using a small screen. Is quite annoying. But was not introduced by this PR so we can fix later.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: improve the way we are writing text inside status chart

2 participants